Bukkit

/recp save command does not save enchantments or potion data of items

Summary

When a recipe is saved using the command /recp save in game, using an item with enchantments, or potion effects. 

What I did

I put these items in this layout in my inventory:

and then ran /recp save test1 shapeless

Expected behaviour

The following should have been saved in crafting-recipes.yml:

test1:
        type: Shapeless
        ingredients:
            'FLINT ': 1
            'POTION:INCREASE_DAMAGE;3600;1 ': 1
        results:
            'GLASS_BOTTLE ': 1

 (I think I've understood the potion item syntax correctly)

As a result, a flint and only a strength potion should yield an empty bottle.

A flint and any other potion should not yield anything.

Actual behaviour

The following was saved in crafting-recipes.yml:

test1:
        type: Shapeless
        ingredients:
            'FLINT ': 1
            'POTION ': 1
        results:
            'GLASS_BOTTLE ': 1

As a result, a flint and any potion yields an empty bottle.

Notes

This behaviour also occurs when using a furnace or shaped recipe.

This behaviour occurs when set as the output item(s).

This behaviour occurs regardless of any other items used in the recipe.

This behaviour occurs with enchanted books and potions.

This behaviour does not occur with enchanted tools or items with custom names or lore.

Environment

(This seems to happen regardless of other plugins or CraftBook configuration, so I am posting the minimum relevant information):

CraftBook 3.9u21

WorldEdit 6.1.7.3

Spigot 1.12.2 with Java 1.8.0_151 on Ubuntu 16.04 LTS

Plugins: WorldEdit, CraftBook

Enabled Mechanics of CraftBook: Variables, Custom Crafting

 /recp save command does not save quantity of non-stackable items in shapeless or furnace recipes

Summary

When a recipe is saved using the command /recp save in game, using more than one of the same non-stackable item in a shapeless recipe causes it to save as having only one item, so the recipe works with only one of these items.

What I did

I put these items in this layout in my inventory:

then ran the command /recp save test1 shapeless

There were no errors in the console, and no client-side error message.

Expected Behaviour

The following should have been saved in crafting-recipes.yml:

crafting-recipes:
    test1:
        type: Shapeless
        ingredients:
            'CAKE ': <strong>2</strong>
        results:
            'GOLDEN_APPLE ': 1

 As such, putting two cake in the crafting grid (in any place) should yield a Golden Apple.

Putting one or more than three cakes in the crafting grid (in any place) should not yield anything.

Actual Behaviour

 The following was saved in crafting-recipes.yml:

crafting-recipes:
    test1:
        type: Shapeless
        ingredients:
            'CAKE ': 1
        results:
            'GOLDEN_APPLE ': 1

 As such, putting one cake in the crafting grid (in any place) yields a Golden Apple.

Putting two or more cakes in the crafting grid (in any place) does not yield anything.

Notes

This behaviour also occurs when using a furnace recipe, even though it is not possible to put multiple non-stackable (e.g. Cake) items in a furnace.

This behaviour occurs regardless of the output items.

This behaviour occurs regardless of any other items used in the recipe.

This behaviour occurs if multiple of different non-stackable items are used (e.g. 2 cakes and 2 beetroot soups) (you have to only use one of each to get the desired output)

This behaviour does not occur when using a shaped recipe.

This behaviour does not occur when using different non-stackable items.

This behaviour does not occur when using stackable items.

Environment

(This seems to happen regardless of other plugins or CraftBook configuration, so I am posting the minimum relevant information):

CraftBook 3.9u21

WorldEdit 6.1.7.3

Spigot 1.12.2 with Java 1.8.0_151 on Ubuntu 16.04 LTS

Plugins: WorldEdit, CraftBook

Enabled Mechanics of CraftBook: Variables, Custom Crafting