TradeMod
Update: 4/12/2016
Taking a quick break from active development. Currently, plans for next update include: currency/economy support, revised help information, command-less accepting/requesting, across game-mode trading configuration, and toggle for max-distance config. Obviously, this may take me a while to implement properly, so give me some time.
What is TradeMod?
TradeMod is a plugin that allows players to trade with one another in a similar vein to games like RuneScape or services such as Steam.
Features
- Safe trading using an inventory window to represent a trading screen.
- Configuration of values and messages.
How do I use it?
Take a look at the HELP page by clicking here OR:
Server Owners
Server owners, please carefully read the config.yml generated upon running the plugin. It should give you all the information you need to start configuring the plugin.
Permissions
trademod.commands.help: If given permission, allows the player to use the /tm help command. Default: true
trademod.commands.reload: If given permission, allows the player to use the /tm reload command. Default: op
trademod.commands.open: If given permission, allows the player to use the /tm open command. Default: true
trademod.commands.cancel: If given permission, allows the player to use the /tm cancel command. Default: true
trademod.commands.request: If given permission, allows the player to use the /tm request command. Default: true
trademod.commands.accept: If given permission, allows the player to use the /tm accept command. Default: true
trademod.commands.confirm: If given permission, allows the player to use the /tm confirm command. Default: true
Source Code
You can find the source here
Questions? Need Support?
You can click here to enter TradeMod's Discord server.
TODO (in no particular order):
1. Economy support using Vault.
2. Administrative commands and features.
3. Logging of trades.
update? :(
@ChillaxTeam
give your rank '-notrade' (negative permission)
you should add a feature where you can just look at the player and do /trade
@Koangaaa
No problem, do you think you can also fix the exploit in forcing the other player to drop their item?
@Koangaaa
Event if the server does not use emeralds, it would make sense to use them for setting the amount of money in my eyes. If you have a window with a butt load of wool blocks, most people will just fail to understand it. Sure, the red/green wool blocks are great because green is "ok" and red is "attention" for most of us. But with more colors involved that'll no longer be a unique mechanism.
Just my 2 cents. Maybe you could just make it configurable with a default setting in the config. That'll fit most of the servers then. Either ay, looking forward to see your ideas in action :-)
Hi I'm japanese. I want japanese language. can i your mod add language?
:)
@xJoshJx
I may have to force an inventory update, as it seems to no longer do it itself. Sorry about that.
Two problems.
One, When player is dragging items in their hand (mouse clicker), and the other user cancels - it force drops the item that was in the players hand (mouse clicker).
Two, When overflow takes place, or when the trade is canceled - the items return to their owners yes, but the items are invisible until the player relogs.
Add support for more languages. when?
@CubeNation
That's what I'm wondering. I don't know how each server's currency systems work, though. For instance, 1 currency point may be equal to 10000 currency on another server, so I have to compensate for everyone involved. This means having a large array of values to input, so that players don't have to worry about spam-clicking a certain block. Also, this is why I want to exclude emeralds. I have more of a variety when using wools, and considering I already use wool blocks as placeholders for buttons, I may as well continue that trend.
@Koangaaa
Sounds nice, although I'd prefer not to add too many wool blocks. Imho it should be enough to have 2 items for this (why not emeralds? ;-) ) Also you could make it so shift+click increases/decreases amount by 10 instead 1.
@FlashIT
I have actually been thinking about a feature that emulates that. Essentially, the window would display both user's current currency offers in the title. As well as that, there'd be several colored wools at the very top of each half of the window. Upon clicking on certain one's, for instance a purple wool, you would increase your currency offer by 1, and if you right click it you would decrease it by one. There'd be several placeholders for general amounts (5, 25, 50, 100, 500, 1000 and so on).
Tell me what you guys think about this, and I'll see if I can muster up the motivation to complete it.
Could you please set up the ticket system for the project, so we could file bugs and feature requests? Would be great!
One more feature request:
We've seen our users are confused if they accidentally close the trading screen not really understanding how to go on then. Also its hard to explain to them how to add money and such using commands since they often believe its just the trading window they need to use after "connecting".
So here's an easier way to add payment to the mod: (I got this idea from the ShopKeepers mod)
You should let the server owner define some item (default could be the emerald) which is shown for both users within each section of the trading window. If you click on it it increases (+1) the emeralds, if you right click it, it decreases (-1) them. There could also be a second large item (emerald block?!) to add even more/faster money.
For sure it should be able to use the player iconomy money for example OR optionally the emeralds from within the user inventory.
You could then just add an option to instantly cancel the whole trade when one user just closes the trade window.
This way the whole plugin would become more interactive without using to many commands and confusing the users. Hope you like the idea.
@ilusions4
I believe this is an issue with the inventory API itself, and I don't know if I can fix it. The items are not actually there, and will reappear in your cursor whenever you force an update (you click, you close the window, etc).
After having moved and having done so many things prior to a few days ago, I literally lost all motivation to even touch both of my plugins. Now, I am ready to come back and work on fixing bugs/adding new features that will help better the plugin as a whole. I will be starting small, such as creative trading restricting (configurable) and full inventory trade canceling (also configurable). Also, /tm will now show the commands (and will highlight /tm help) so that players can more easily learn to use the plugin. Thanks for your patience, and I'm sincerely sorry for the delay.
instead of letting people know which side (top/bottom) is theirs, would it be possible to always let the own side be the top one? would make things a lot easier.
You should make it so that when both accept trade it doesn't confirm immediately... Instead it takes lets say 3 seconds so that they can cancel it if they try to scam them!
@tacticalsk8er
I am finding something wrong in 1.3.1 and 1.3.2... I can put items into both halves of the trading menu... that's about all I can see so far though... can you please help me with this because I even made a giant hall dedicated to this plugin... Ty, ilusions4
@ok12Boss
Seems to work fine on 1.3.1. Giving no errors on start up. Will be doing more testing and update if I find anything.
Edit: Everything seems to be working fine. Although I do have a request and it is quite simple. When players type /tm make it open the help page. That is all. Thanks for making a great plugin. :)
When will release v1.3.1 ?