#663 Shift + click sells/buys all - Issues - ChestShop (iConomyChestShop) - Bukkit Plugins - Projects

Shift + click sells/buys all #663

Accepted

Open

Assigned to

acrobotpl

Forge_User_50771063 created this issue May 31, 2013

Was told to make a ticket out of this, so here's goes...

Before the latest patch, we used to be able to sell everything out of the inventory to a shop, or buy all of it's content.
However, this have been removed, and replaced by a function in my opinion terrible.

It would be great if you could just re-use your old code, put it back as an (perhaps invisible?) option.
It's really useful when selling lots of items, and don't want to constantly click the sign, either causing lag to the server, or having to wait ages to sell everything.

Me and my server would love you over and over if you added this <3

What we're seeing tons of right now:

2013-05-31 21:51:38 [INFO] [ChestShop] *player* sold 64 Sand for 1.00 to Server Shop at [world] -25, 65, 260
2013-05-31 21:51:39 [INFO] [ChestShop] *player* sold 64 Sand for 1.00 to Server Shop at [world] -25, 65, 260
2013-05-31 21:51:40 [INFO] [ChestShop] *player* sold 64 Sand for 1.00 to Server Shop at [world] -25, 65, 260
2013-05-31 21:51:43 [INFO] [ChestShop] *player* sold 64 Sand for 1.00 to Server Shop at [world] -25, 65, 260
2013-05-31 21:51:46 [INFO] [ChestShop] *player* sold 64 Sand for 1.00 to Server Shop at [world] -25, 65, 260
2013-05-31 21:51:48 [INFO] [ChestShop] *player* sold 64 Sand for 1.00 to Server Shop at [world] -25, 65, 260
2013-05-31 21:51:49 [INFO] [ChestShop] *player* sold 64 Sand for 1.00 to Server Shop at [world] -25, 65, 260
2013-05-31 21:51:50 [INFO] [ChestShop] *player* sold 64 Sand for 1.00 to Server Shop at [world] -25, 65, 260
2013-05-31 21:51:51 [INFO] [ChestShop] *player* sold 64 Sand for 1.00 to Server Shop at [world] -25, 65, 260
2013-05-31 21:51:53 [INFO] [ChestShop] *player* sold 64 Sand for 1.00 to Server Shop at [world] -25, 65, 260
2013-05-31 21:51:54 [INFO] [ChestShop] *player* sold 64 Sand for 1.00 to Server Shop at [world] -25, 65, 260
2013-05-31 21:51:55 [INFO] [ChestShop] *player* sold 64 Sand for 1.00 to Server Shop at [world] -25, 65, 260
2013-05-31 21:51:57 [INFO] [ChestShop] *player* sold 64 Sand for 1.00 to Server Shop at [world] -25, 65, 260
2013-05-31 21:51:58 [INFO] [ChestShop] *player* sold 64 Sand for 1.00 to Server Shop at [world] -25, 65, 260
2013-05-31 21:52:00 [INFO] [ChestShop] *player* sold 64 Sand for 1.00 to Server Shop at [world] -25, 65, 260
2013-05-31 21:52:01 [INFO] [ChestShop] *player* sold 64 Sand for 1.00 to Server Shop at [world] -25, 65, 260
2013-05-31 21:52:02 [INFO] [ChestShop] *player* sold 64 Sand for 1.00 to Server Shop at [world] -25, 65, 260
2013-05-31 21:52:03 [INFO] [ChestShop] *player* sold 64 Sand for 1.00 to Server Shop at [world] -25, 65, 260
2013-05-31 21:52:05 [INFO] [ChestShop] *player* sold 64 Sand for 1.00 to Server Shop at [world] -25, 65, 260
2013-05-31 21:52:07 [INFO] [ChestShop] *player* sold 64 Sand for 1.00 to Server Shop at [world] -25, 65, 260
2013-05-31 21:52:09 [INFO] [ChestShop] *player* sold 64 Sand for 1.00 to Server Shop at [world] -25, 65, 260
2013-05-31 21:52:11 [INFO] [ChestShop] *player* sold 64 Sand for 1.00 to Server Shop at [world] -25, 65, 260
2013-05-31 21:52:12 [INFO] [ChestShop] *player* sold 64 Sand for 1.00 to Server Shop at [world] -25, 65, 260
2013-05-31 21:52:13 [INFO] [ChestShop] *player* sold 64 Sand for 1.00 to Server Shop at [world] -25, 65, 260
2013-05-31 21:52:14 [INFO] [ChestShop] *player* sold 33 Sand for 0.52 to Server Shop at [world] -25, 65, 260

Forge_User_50771063 added the tags New Enhancment May 31, 2013
AcrobotPL removed a tag New May 31, 2013
AcrobotPL added a tag Accepted May 31, 2013
MarkehMe posted a comment Jun 6, 2013

If the spam is an issue, maybe the user/console shouldn't be notified until say 3 seconds after.

However, if in that 3 seconds gap a purchase is made, a message is not sent.

If after the 3 second gap there has been more than 1 purchase (lets call this [x]) it will send:

[ChestShop] *player* sold [x] * 64 Sand for 1.00 to Server Shop at [world] -25, 65, 260

That way when someone is "buying all" (aka, click click click click click ..) it won't spam, instead give a healthy number :)

Edited Jun 6, 2013
Forge_User_50771063 posted a comment Jun 8, 2013

The spam isn't an issue, the issue is that people now have to spam it really bad, just to sell their damn items, which could be done with just a click, and be done in just a second.
l0rd_rahl posted a comment Mar 18, 2014

This makes sense, especially for those shops that have thier quantities set really low, like 1 or 2 items, you have to click a million times to sell your stuff....would be nice to shift click and sell all

To post a comment, please login or register a new account.