Bukkit

What steps will reproduce the problem?

1. Have at least 2 groups, one with at least 1 tier higher backpack upgrading permissions than the other.
2. Start in the lower tier group, buy the max upgrade where it will then say, "You already have your Max Size!," then get put in the higher tier group.
3. It will give you more available upgrade(s), but the text "You already have your Max Size!" will be inside of the upgrade size text.

What is the expected output? What do you see instead? Text. Text inside of text. :P

What version of the product are you using? Latest (b126)

Do you have an error log of what happened? No

Please provide any additional information below.

Upgrade Needs Fix, Not Necessarily Bug:

Currently, the backpack upgrades are cumulative, so even with "1000" per backpack upgrade in the config, the last backpack from size 9 to 54 would be priced at 5000. This is fine if the buying was restricted to "upgrading," not skipping upgrades. What I mean is player one could buy his size 18 pack, 27, 36, 45, and 54 to get to the max, spending a total of 15000 (1000 for 18, 2000 for 27, 3000 for 36, 4000 for 45, 5000 for 54, since it strangely adds that way). On the other hand, player 2 could simply skip upgrades 18, 27, 36, and 45 and simply purchase size 54, spending a total of 5000 for the exact same result. This should not be the case for 2 players getting the exact same thing at the end.

A simple fix would be to force "upgrades," so players could not skip upgrades; they would have to buy each one before the next.

Another possibility would be to deduct the current upgrade's price from the new upgrade's price when upgrading (making upgrading non-cumulative), so a player could skip size 18, buy 27 for 2000 (2000 - 0 [default size]), buy 45 for 2000 (4000 - 2000), then buy 54 for 1000 (5000 - 4000), spending a total of 5000. So it would simply subtract the total cumulative price from the next cumulative price up.

Either way you think is best, I really think this needs to be part of the plugin. It doesn't make sense having different prices for the same product. Thanks for the awesome plugin otherwise. Hope to hear back from you soon!

Hm, I may give this some consideration. It warrants discussion for sure.

I sure hope so! Seems like it wouldn't be too hard to implement, but would make it a lot more balanced. Thanks and I hope to see it in a future version soon! :)

Fixed in b129.

One problem was fixed, the other was not. You made all backpack upgrades add correctly now, like shown in the config, but players can still skip sizes. So instead of paying for size 18, 27, 36, 45, they could simply buy 54 and pay the 54's price without ever paying the other size's prices.

This cannot be exploited with Spout off since size upgrades are done for you and can't be skipped, but with Spout, it is a pretty hefty advantage. Simple solution would be to force upgrades or just charge the previous, unpurchased upgrade(s) prices on top of the new, larger ones.

I will make a new ticket.