LB drops should not affect bedrock or other strong blocks #34


  • Defect
  • Accepted
Closed
Assigned to mcgamer199
  • SpigotSlimeDog created this issue Jan 4, 2018

    Spigot 1.12.2 latest

    LB 2.2.3

     

    LB structures replace any existing blocks, even those that are considerably stronger. This is not desirable, especially if the existing block is bedrock or a command block.

     

    Minimally: Please create a configuration option to suppress this.

     

    Optimally: LB structures should not replace blocks stronger than the constituent blocks of the LB structure, according to the blast resistance table. For example, the LB structure that is composed (mostly) of iron blocks should not replace any of the following, at least as far as EnderChest (one could plausibly argue that lava and water should be replaced):

    Barrier 18,000,003
    Bedrock 18,000,000
    Structure Block 18,000,000
    Command Block 18,000,000
    End Gateway Block 18,000,000
    End Portal 18,000,000
    End Portal Frame 18,000,000
    Anvil 6,000
    Enchantment Table 6,000
    Obsidian 6,000
    Ender Chest 3,000
    Flowing Lava 500
    Flowing Water 500
    Lava 500
    Water 500
    Dragon Egg 45
    End Stone 45

     

     This could be an option, of course. Some servers might want to allow it.

  • SpigotSlimeDog added a tag Defect Jan 4, 2018
  • SpigotSlimeDog edited description Jan 4, 2018
  • MCGamer199 self-assigned this issue Jan 5, 2018
  • SpigotSlimeDog edited title Jan 5, 2018
  • SpigotSlimeDog posted a comment Jan 5, 2018

    Likewise, rain of arrows should not penetrate bedrock or the other strong blocks.

     

     

     

     

     

     

     

     

     


    Edited Jan 5, 2018
  • SpigotSlimeDog edited description Jan 5, 2018
  • SpigotSlimeDog edited title Jan 5, 2018
  • SpigotSlimeDog posted a comment Jan 6, 2018

    Just to be clear, I am available to test these changes. Please let me know what you would like me to do.

  • MCGamer199 posted a comment Feb 2, 2018

    Which drop is causing this?

  • SpigotSlimeDog posted a comment Feb 2, 2018

    Any plugins/LuckyBlock/Drops/default/structures/ build. If the new structure intersects bedrock, it replaces the bedrock.

     

    Suggested algorithm: LB structure blocks should not replace the following hardness=infinite blocks:

    • barrier
    • bedrock
    • command block
    • end portal
    • portal
    • structure block
  • MCGamer199 posted a comment Feb 4, 2018

    I mean is it CUSTOM_STRUCTURE or SCHEMATIC_STRUCTURE drop that is causing this bug? If it's SCHEMATIC_STRUCTURE then it would be impossible to control this as it's a worldedit function that i'm using.


    Edited Feb 4, 2018
  • SpigotSlimeDog posted a comment Feb 4, 2018

    I prefer not to have players destroying intentionally-static elements of the environment. They are constructed of bedrock, so they cannot be destroyed, but LB structures replace them, and a clever player can place lucky blocks to do so.

     

    Does the answer above imply that CUSTOM_STRUCTURE elements do not have this characteristic?

     

    If yes... None of the structures is that large. Could they be translated into CUSTOM_STRUCTURE elements, so that this issue can be addressed? If not, I will have to remove the SCHEMATIC_STRUCTURE elements from the lists.

     

    If no... I will have to remove both kinds of structure elements from the lists, unless you can implement a fix for CUSTOM_STRUCTURE elements.

     

    It would not be that difficult to remove them, but it would be nice to keep them in the lists.

     

     

  • MCGamer199 posted a comment Feb 5, 2018

    I don't think that schemtatic structures replace blocks (never tested  that) but if it's just happening with custom structures then it would be easy to fix it. You can translate schematics to custom structures via "/lb saveStructure" command but certain blocks won't be saved correctly.

  • SpigotSlimeDog posted a comment Feb 5, 2018

    Please fix it for custom structures and we'll move on from there.

  • MCGamer199 posted a comment Feb 7, 2018

    Please check if schematic structures are causing this too.

  • SpigotSlimeDog posted a comment Feb 7, 2018

    It would be very helpful to be able to log which item is awarded. If fact, that would be a useful option always.

     

    So, I constructed a luck array that has only structures. A haybale structure replaced bedrock, so I would say that the answer is yes.

     

    On my production server, I have structures disabled (ie., not included in the luck array).


    Edited Feb 7, 2018
  • SpigotSlimeDog edited title Feb 7, 2018
  • MCGamer199 closed issue Feb 25, 2018
  • MCGamer199 added a tag Accepted Feb 25, 2018

To post a comment, please login or register a new account.