Trade
Trade
Trade with other players!
How to install/use Trade:
Thanks to Skaranova for making this video!
Features:
- Command less trading using right click to request players
- No Spout required
- Very easy to use trading screen
- Customizable messages
- Economy support Since version 0.3
Translations:
You can find translations on this page!
Commands:
Okay, there are a few commands. But they are completely optional.
- /trade <playername> - Requests the named player.
- /trade accept <playername> - Accepts request of named player.
- /trade refuse <playername> - Refuses request of named player.
- /trade ignore - Ignores all incoming requests.
- /trade reload - Reloads the yamls.
Permissions:
See this page!
Configuration:
See this page!
Dependencies:
- Optional:
- Vault if you want to use the economy trading screen
To do list:
- Permission based layout system
- Log/Rollback system
Reporting bugs:
If you found a bug in the plugin please be so kind to file a ticket here. It only takes little time to file one while helping me to keep things organised and fix these bugs quicker.
Known Issues:
Trade was rewritten after version 1.0. Version 1.0 is currently in BETA. It is not completely safe to say the BETA version does not contain any glitches at all but it is safer than any of the previous versions. If you want to use Trade use at least the BETA version"
Development builds:
Development builds of this project can be acquired at the provided continuous integration server. These builds have not been approved by the BukkitDev staff. Use them at your own risk.
https:josvthfoss.ci.cloudbees.com/job/Trade/
Source available on Github
If you like what I'm doing. Consider donating :) Please use the donate button in the top right.
@josvth
Just a small adjustment to my request, about requiring players to be in sight of each other for trading. I realized that I don't want don't want players to abuse the trading system to do stuff like send diamonds from the depths up to a friend on the surface to guarantee they won't lose them by falling in some lava. Instead of allowing for trading from anywhere, can you keep a requirement that if the trading players are in survival mode, they can't start a trade session unless they're both above sea level? I think this will strike an effective balance, and still be very easy to implement. Thanks! :)
@josvth
i say xD
@josvth
for me, since after using the trade plugin with rob, whenever i tried to use something after dragging it from the inventory to the quickbar slots, i would go to use it and it would dissappear and also for example, if i picked up a stick from my inventory and placed it on a plank in my hotbar, replacing what was in my hand so i'm holding the planks and not the sticks, i place the planks back and then the sticks disappear, replacing the plank back where it was in the hotbar while staying in the inventory. also with food, i had 26 porkchops, tried to eat 2 of them, they dissappeared instantly, not even healing me
[22:46:08] Michael Tanner: which could be a huge problem for pvp fights
[22:46:52] Michael Tanner: it sounds like the plugin that replaces whats in your hand when you use it up with the same material in your inventory is broken due to the trade plugin
@deleted_7536780
Could you describe a situation when this happens? Is it when using shift like Icefireburn1 said?
there are some duplication issues and item loss issues.
@josvth
Yes it does send a trade request to them, which is kind of a problem because it overrides the "Questers" quests. Therefore it sends the request, but blocking the opportunity to receive a quest.
@Xunzi
As I've said in my reply to bigscary I'm planning to add economy support (probably through Vault). But I will focus on grinding out the glitches and exploits first.
My plan for economy support is adding items to the trading screen that each represent a value like 1, 5, 10, 100. Maybe using gold nuggets/ignots and diamonds. Or maybe iron/gold/diamond blocks, those might be clearer.
With left clicking you can add a value and right clicking will remove it from your offer. The amout of items representing the money values will change accordingly to the money you offer.
I have a big suggestion here, because practically every person on my server has suggested it - Might it be possible to add support for economy plugins? For example, when you trade, you should be able to add certain amounts of money to the offer as well, but not money that is in a physical form. I'm referring to digital money such as that which is found in EssentialsEconomy and iConomy for instance. This way, players would be able to trade a LOT more openly, and it was provide a very secure way of selling to or buying from other players. Basically, the whole transaction would be done through you plugin so that people could avoid using /pay (username) and THEN trading for the item. Doing it that way would make it much easier to scam people or be scammed, as the other person may just take the money and leave before giving you your item(s). If you could get back to me on this, that would be excellent.
AMAZING plugin, by the way! Our players use it daily to its full extent; they just want more out of it.
Thanks
- X
@Icefireburn1
By interfering with citizens you mean you can send trade requests to npc's? That would be fun if it actually worked :p However I will try to block this.
For the shift clicking I initialy blocked it, cause items vanish if you shift click them and your side of the trade inventory is full. I will check if I could fix this.
Can you make this plugin compatible with citizens? It interferes with like every type of npc.
EDIT: Permissions would fix this. Also when shift-clicking an item to add to the trade menu, it will go into the menu for a moment, then back to your inventory. After the trade is complete, the item (if it was not successfully traded) will be dropped on the ground, despite the fact that it was in the players inventory.
Amazing :D
@bigscary
Thanks! I hope I didn't let you waste hours on the development of your trade plugin.
I will add a simple /trade <player> command with configurables for cross world trading and wether you have to see a player to trade with him.
For economy servers I was thinking of placing buttons like the accept and refuse to add money into the trade. Like having a golden nugget, ignot and a diamond each representing a value respectivicly 1, 5, 10. Left clicking a button will add the value to the trade, right clicking removes it. However I would like to focus on removing glitches and exploits before adding big features.
I'm not planning to add support for your GriefPrevention plugin. Not because I don't like it but I don't want to add support for X plugin if little people have benefit from it. It would also cost me more time keeping it up to date if I promise support for a lot of plugins.
That said. Thanks for the feedback it's very usefull!
First of all, NICELY DONE. I've been working on a command based trading system to eliminate trade cheating (dropping not-full stacks, or a different enchanted item). Now I'm just going to drop it, even though it's almost done, because this commandless design is infinitely better.
Please add a very simple slash command like /trade <player> to allow for trading over big distances, because many server owners (including myself) will want it. Your plugin will be especially helpful for PvP servers, because it will allow players to trade without making them vulnerable to PvP, or requiring them to travel to a no-PvP safe zone for trading. I understand that some will want your requirement to see the player you're trading with, but please make it possible to turn that off. I want to eliminate travel for trading, and that would require players who are very far apart to travel just to trade, which will reduce trading overall, especially for small trades, and I don't want to inhibit players from working together by trading. Also on my PvP server there are no safe zones, so you can see where having people get within eyesight of each other to trade could be a problem. :)
Please add an option to block trading across worlds, simply because some servers run multiple worlds where they don't want items crossing over (like creative vs. survival worlds, or pvp vs. non-pvp worlds).
The only thing I'm concerned about is bringing economy into the equation. So many servers use a currency, and yet there are no items representing that currency under most systems. How will you allow for trading items for server currency? Maybe a slash command to offer up an amount?
Please add GriefPrevention plugin integration to block players from trading while they are under siege, which would make it possible for them to transfer their items to another player, thereby preventing the enemy from getting their good loot.
Thanks again so much for tackling this problem and designing a very elegant, easy-to-use solution!
@josvth
Well what happens is when I'm building or eating or fighting something and someone walks infront of me and i right click to throw an egg or potion or snowball the trade thing comes up. and sometimes i click several times before noticing.....
@lord_moonscar
But if you request someone it doesn't send him a message more than once right? If it does, it's a bug. :p
I agree with the crouch and right click, it would make it less spamming :D
Just wanted to say I love this plugin, it works perfect, ty.
really looking forward for new features !!!! great plugin
Great Plugin Few Suggestions!
@THDigi
Yeah it's in alpha stage so not all of dupe/exploits are found and fixed. Do you know how this guy did this exploit? Maybe you can show it on my test server.