Trade
Trade
Trade with other players!
How to install/use Trade:
Thanks to Skaranova for making this video!
Features:
- Command less trading using right click to request players
- No Spout required
- Very easy to use trading screen
- Customizable messages
- Economy support Since version 0.3
Translations:
You can find translations on this page!
Commands:
Okay, there are a few commands. But they are completely optional.
- /trade <playername> - Requests the named player.
- /trade accept <playername> - Accepts request of named player.
- /trade refuse <playername> - Refuses request of named player.
- /trade ignore - Ignores all incoming requests.
- /trade reload - Reloads the yamls.
Permissions:
See this page!
Configuration:
See this page!
Dependencies:
- Optional:
- Vault if you want to use the economy trading screen
To do list:
- Permission based layout system
- Log/Rollback system
Reporting bugs:
If you found a bug in the plugin please be so kind to file a ticket here. It only takes little time to file one while helping me to keep things organised and fix these bugs quicker.
Known Issues:
Trade was rewritten after version 1.0. Version 1.0 is currently in BETA. It is not completely safe to say the BETA version does not contain any glitches at all but it is safer than any of the previous versions. If you want to use Trade use at least the BETA version"
Development builds:
Development builds of this project can be acquired at the provided continuous integration server. These builds have not been approved by the BukkitDev staff. Use them at your own risk.
https:josvthfoss.ci.cloudbees.com/job/Trade/
Source available on Github
If you like what I'm doing. Consider donating :) Please use the donate button in the top right.
@Pr07o7yp3
Yeah, I saw it. I'm in London atm and there are not a lot of places with free Wifi. But yeah from the looks of it it seems like a bug in the Bukkit inventory api. I will try to take a look at it when I'm back monday.
@josvth, did you see the video? What do you say?
Ok, i did a video for the bug: http://www.youtube.com/watch?v=R50mI05BWQY
Thx for updating =)
@TacImpulse
Hello TacImpulse,
To enable economy you must add 'economy: true' without the quotes inside the config.yml. Or you could just remove the config.yml and it will add the configurable. I forgot to mention this, sorry.
The item glitches are a Minecraft/Bukkit bug. Sometimes when you trade a single item it will not show up in your inventory though they are there and other players can even see the item if you are holding it. Untill Bukkit adds a working update inventory function there's not much I can do.
Greetings,
Josvth
Great plugin, and I'd love to use it on our server. But I'm not seeing the trade window currency options. I've got economy set to true in config and we're using essentials for our economy plugin.
When trading, all we see is wool and sticks. And it seems to work, for the most part (barring a few graphical glitches when trades are cancelled: sometimes items will not show back up in your inventory until after reconnecting to server).
Either of these issues could certainly be due to some obscure incompatibility issue on our end, as we do have a few plugins on the server.
Any basic ideas as to what I may have missed?
Thanks!
@Pr07o7yp3
First for your bug. Is this only when the trading gui is opened? If so it kind of intended but it can be fixed if you could tell me why you would want to throw away items while trading. :P
For your proposal, It was my intention to do it as you propose. But Bukkit doesn't let me change the names of inventories. I can only set the name when I make one. What I could do is make a new inventory and open it every time a player adds or removes money but that would make things way more complicated and insecure when the server is laggy. If you could live with having it this way that would be awesome.
You can remove added money by right clicking the currency items. ;)
Ok, I have 1 proposal and 1 bug.
First the bug: With this plugin the players can't drop items to the earth direct from their inventories. It works only with the button "Q". :(
And now the proposal: It's about new economy system. Can you do next to the names (Yes and <Player>) to shows how much money they added. Example: If I add 50 $ above to the names to show: You (50$) Player (0$)
Also can I have remove added money?
Please add config custom economy unit. :)
Thank you plugin. you Awesome.
@si88
Hello si88,
Yes, I'm planning economy support as a complete optional. As I said before though I completely dislike any form of economy in Minecraft because I think it shouldn't belong in this game and there should be a focus on item trading, I will still add the functionality to this plugin because a lot of people are requesting it and without it this plugin would be lacking potential.
This is how I had the economy support in mind. I will add 3 more items to the left side (you're side) of the trading gui. Say a golden nugget, a golden ingot and a golden block. Each of these representing respectively a currency of 1, 10 and 50. When you left click one of these items it will add the value to the trade and the amount of the item will increase. Right clicking would subtract the value from the trade.
If you have any suggestions on how I should implement the economy support let me know.
Awesome plugin! One thing i'd like to see is economy support in the window without typing commands if this is at all possible? typing a command whilst having a trade window open is difficult.
@GeoCraft
I can confirm that. When a player is dragging an item from his inventory to the trading gui at the same moment the other player cancels the item will be dropped. I will fix this in the next build.
The use_biggest setting is for when two players are trading that have different gui sizes. Say a player with the permission to use 6 rows wants to trade with a player that only is allowed to use 3 rows true will let them trade with 6 rows, false will let them trade with 3.
Ya, it seems like if I trade with someone and cancel the trade when they are placing their stuff, their stuff gets dropped on the ground allowing me to steal it. EDIT: Also, what does setting use_biggest: false do?
@Smellyhobo101
You can set right_click and shift_right_click to false in the config.yml. :)
I'd like to not use the right click to trade feature since people are accidentaly using it while trying to activate their MCmmo abilities while PVPing. How do i disable it but still allow people to trade with /trade?
@Matthiaswagg
Hello Matthias,
This could be a Bukkit problem. Sometimes the contents of an inventory or a crafting grid becomes unsynchronised with the players that are viewing it causing blocks to become invisible. What you are describing never happened to me though but I shall see if I can find more info.
I still have the glitch where if you press esc during a trade, the stuff you have placed in trade window gets thrown on the other player, allowing them to steal.
There is a glitch where the wool doesn't show up until you click the spot where it is. No error messages - still can accept and reject, but you can't see the wool
EDIT: I have reloaded the config, reinstalled the plugin, restarted the server, and tried using another computer. Nothing works. My current config is sneaking and right clicking works, so it wont conflict with right clicking uses for my other plugins:
Cenotaph, CensorShip, Chairs, Trade, Ptweaks, QuantumConnectors, EasyEnchant, MagicChest, MineCal, Courier, MuddersMilk, PermissionsBukkit, PorteCoulissante, CraftBukkitUpToDate, Gods, Poll, EnchantMore, TreeAssist, DeathTpPlus, ForcedGrammar, TheAnvil, and EnhancedPistons.
Is there any reason this would happen, and any way to fix it that I haven't already tried?
@nhoclesnar
You can disable the feature in the config.yml. Just set right_click and shift_right_click to false.
Hey can you please add a command to turn off the right click trade mode? I found it very annoying when I'm talking to NPCs and selecting them.