Rpg Trade
MAJOR NEWS
I have decided that we are going to be merging all of the RPG style plugins into a single plugin, Servers that want to only use a few features from them will still be able to do so through our config files. The RpgAPI page we have will be the one the plugin gets released on. It is taking a bit longer than expected to get them all updated but we are trying to make them as configurable as possible so every server can use them exactly how they want to.
Rpg Trades
Major update V1.5
Rpg trades is a system that allows you to open a trade window between you and another player for safe trades.
Permissions
trade.invite
Features:
- trade between 2 players with a inventory based gui.
- both players must hit the "confirm" wool before a trade will go through
- if one player changes an item both players have to re-confirm so no last minute trade scams!
- multiple items can be traded at once!
- the trade system can also be used to give a player items, as long as both people confirm only one side needs items!
- set how long players have to accept a trade in config
- set how far away players can trade from in config
- set only local trades to false in config to allow trading across any distance or world!
Commands
/trade {playername} - invites a player to trade with you!
V1.5 /trade invite {playername} - invite term can be changed in config
/trade accept - accepts a pending trade invite
/trade deny - cancels a pending trade invite
Config File for V1.5
#whether players have to be within a certain distance to trade with one another onlyLocalTrades: true #if only local trades is true, this is how close a player has to be to trade TradeDistance: 10 #how many seconds before an impending trade invite is cancelled inviteTimeOut: 30 #words to display to players under different circumstances. #These are considered self explanatory so won't be elaborated upon #colors can be used with @# a.k.a. @2 = green #the first five are wrapped in '' so that the initial space will be placed in messages after a player name. Terms: Has Invited: ' Has Been Invited To Trade.' Is Invited: ' Has Invited You To Trade. please use @2trade accept @for @4trade deny.' Accepted: ' Accepted the trade.' Denied: ' Denied the Trade.' Too Far Away: ' is too far away!' Not In Trade: you are not in a trade! Error: Syntax Error use accept deny or invite! NoPerm: You do not have permission to trade! Missing Player: Cannot find player. Same World: This player must be on the same world as you! Complete: Trade Completed. Block Accept: Accept Block Deny: Deny Block Waiting: Waiting. Block Confirmed: Confirm #do not use colors in these, these are the commands players have to type in to use the trade features. Command Invite: invite Command Accept: accept Command Deny: deny
massive credit and thanks goes to RC2K7 for starting the work on this plugin and getting most of the hard stuff out of the way :)
My RPG Plugins
Rpg Click
Help fund my programming hobby :)
I'm always available to help with issues with this plugin. feel free to log onto my ts3 at voice.vartala.com or add soulofw0lf on skype (Make sure you include why you're adding me or i will likely ignore it.)
@diannafire
For the mean time as a temporary fix couldn't you just add a line or two of code that uses Bukkit.dropItem (it may not be those exact words as a while since i used the exact line) to drop the excess items at the feet of the player with the full inventory
@SheerAwesomeness
When the api is done and the mail feature is added in accepted items will get mailed to you if you have a full inventory. In the mean time i'm aware of it and recommend making sure you have inventory room before accepting a trade.
Uhh, great plugin mate, but uhh. Whenever I accept items when I have a full inventory, the items disappear. They are in neither persons inventory or on the floor.
@Hedgehogs4Me
yeah the cobble thing is a bug that is completely eluding me as to what could possibly be causing it. as for the trade invite i just forgot to put a check for enough arguments into it, with the release of the api that will be fixed.
It seems to be removing all cobble put into the trade window, but only cobble. Is that intentional? Can I turn it off?
Also, there's a rather large bug that seems to create a command exception and toggle the plugin working at all. I'll submit a ticket for that.
EDIT: Wow, I said that before checking if I can submit a ticket. Basically, if you type "/trade invite" without a name, it'll create a command exception that can only be fixed by typing "/trade invite" again. I'll put the full error here if you want, but I'm sure no one wants that unless it's specifically requested.
@MrREOM
that is already implemented in our current version of the api and tested to work, soon as the api is out you'll have a lot of control over when and how a player can trade.
Could you make it so there's an option to disable Trade in some worlds and disable trade when people are in creative.
@Crolele
I wish i could give you a deifnitive date but at this point in time i don't really have one, there are two of us working on it alot so we're getting it done as quickly as we can.
@Apple_columb
tested this on my server it does not steal the items though a client side graphics glitch can make it appear as if you have the items until you try to use them at which point they disappear when your inventory updates client side. if the items are actually staying in your inventory then you may have another plugin interfering.
How to steal items with Rpg Trades V1.5:
1. Start trading with someone
2. Wait until other person put something on right side
3. Cancel trade
@Crolele
I'm already working on a classes system as part of my rpg api but it will actually have a max level of 20 and levelling will be a long process.
@umegonta
I'm going to assume you are using an old version of the plugin because shift clicking has been disabled for a while now
I do not mean criticism but this plugin has rather CRITICAL bug. People can trick other player asking them try shift+click to put your items. There is bunch of "ninjas" in my server asking new players trade something in good deal just to steal items. This is can be succeed real easy due to the fact first person typed "/trade playername" usually gets benefits of stealing items.
This is how it work;
1. Person A will type "/trade Person_B" 2. Person B will type "/trade accept" and it opens an "container" which supposed to be Person A can only put items on left side of wool signals, and Person B can only put items on right side. 3. Person B gonna click while pressing shift because he prefer to do so. 4. Person B's item gonna transfer into LEFT SIDE which not supposed to go there because the trade windows is in fact just a chest. 5. Person A can "steal" items directly because the "LEFT SIDE" is supposed to be for Person A. Person B cannot do anything after he/she put his/her own items vis shift+click. 6. Person A can either accept or deny trade and Person B's item is gone.
For now our only solution is teaching players do not use shift+click while trade.
Of course the shift+click can also put items as much as they can and players are able to put items beyond their own "trade chest" area. There is a lot of strategy to trick players.
I am not plugin specialist but authors should able to make players not allow using shift+click while trade because Diannafire already done this in the "trade chest" area. I hope Diannafire going to fix this issue.
@KunkIsMyName
No the problem exists on my server as well but i have no clue why.It will definately be fixed in my rpg api suite that all the plugins are being combined into. I have no clue why it's doing it since the only block that's mentioned in the code at all is air, but i'll get it figured out.
@diannafire
Ty for your support. Btw i have an idea. Can u try test trading cobblestone with someone(at your own server or somewhere) ? Maybe just I have this problem with my server, if i do i dunno why and u dont have to think about it anymore. Cos i can see that u re good guy, i dont wanna waste your time :D
@Crolele
does everything else with your permissions still work ok?
@KunkIsMyName
I'm still trying to figure out what could cause that but as of right now i have no clue at all sorry :(
Well i am using permission ex , advanced afk, health bar, infobook, lockette , loginsecurity, residence, simplechat and ofc rpg party and trades :D Btw i like your work I have no errors. I can keep trading but cobble will dissepear UPDATE1: Lemme know what did u found out
@KunkIsMyName
I have no idea at all, nothing in my code should cause that to happen... I will look more in depth into it. any errors you are getting and what other plugins do you use?
Everything is working fine expect trading with cobblestone. When take it to the trade window it just disspear. Any idea how to fix it ?