CitiTraders2
CitiTraders
Cititraders enables your citizens 2 NPCs to act as traders, buying and selling goods. It works good for admin shops and player shops alike. All traders use the inventory interface for buy/sell and players don't need any commands to interact with Traders.
You can see more details at CitiTraders Wiki
Setting Up A Trader
Interacting
- Right Click the NPC
- Opens the selling window, here the players will select what item they wish to purchase from the NPC
- Right Click the Item
- displays a price of the item
- Left Click the Item
- Opens the final sales window, from here a player can right click again for stack price, or left click to purchase the stack
- Left Click the NPC
- this will open the buy window for NPC, currently players need to just drag and drop items to the inventory and close the window, unpurchased items are dropped if NPC can't purchase these items (soon they will not be able to be dropped into the inventory if NPC can't purchase them)
Adding Stock
- Right Click the NPC with a BOOK in your hand
- This will open an inventory screen where you can place any items you want to sell, if an ADMIN shop these items will not be reduced with sales, but you still need to put 64 (or max stack) of an item to get a full listing of amount in sales window.
- Linked Chests
- If you have linked chests, adding stock is as easy as opening the chest that is linked to the trader, and adding what you want to it.
Commands
Commands Permissions are currently listed here for CitiTraders 2
Permissions
Limits/Profiles
Installation
Just place into the plugins folder and restart the server, make sure you have a working version of Citizens2 and Vault installed first
Requirements
- Citizens 2
- Vault with economy plugin such as BOSEconomy and permissions such as zPermissions.
- (Optional) Towny
TODO
- Add new text to localization file.
- Verify Towny support
Credits
- tehbeard - Original Author
- tenowg - Past Maintainer
- twillen - Current Maintainer
Latest ver. 2.0.4 and it seems chest linking is a bit buggy. At the moment if I put say 200 iron ingots in the chest and go to the trader I can buy the 64 stack and it gives me 64 and gets rid of all the iron ingots. This is the same for all items being able to buy more then 64. Also enchanted items don't seem to work, the stockroom is empty when you click on them and price is "0". Also the stock in the chest never changes no matter what wallet type it is.
EDIT: Suggestion, add enchanted items under their main item tabs so if I open up iron chest, the enchanted chest is in the storeroom instead of creating a separate storeroom for the enchanted chest.
Any chance we could make the actual shop inventory a bit more aesthetically pleasing? Maybe retaining the layout of the stockroom (which seems to stay fine)?
@Twillen
Ya, still having major problems, had to disable all cititraders people were taking advantage of the problem and getting millions worth of free items. When you first click on the npc to open up the buy window and it displays what is available to buy you can shift click the items in that display and it will give it to you without charging you, a message saying you bought something doesn't even show up.
EDIT: I might have found the problem, it looks like a conflict between this and StackableItems
EDIT 2: It is StackableItems, unfortunately its a core plugin of the server that I can't get rid of :(
I may have jump on Faldonboy's report to quickly. I failed to relies during my first round of testing that the trader I was testing with had an admin wallet, and the infinite items I was receiving was intended. I'm unable to find the reported bug, and 2.0.5a is still on its way. 2.0.5a has a small fix to the update notification I broke in 2.0.5. Once 2.0.5a is up, please feel free to test and report any bugs on the ticket page or here in the comments. Faldonboy, if your still having issues, let me know in the pm or here and I'll try to work with you and find out what's going on.
@Faldonboy
Thanks for the quick report. I've taken down build 2.0.5 due to a significant bug. I recomend those that updated to roll back.
Edit: NVM it isn't permissions its a really nasty bug that lets people get infinite items from the shop, I've pmed you how to reproduce it.
@Twillen
Thanks for updating this.
@Twillen
Awesome, thank you.
I've just uploaded a new build. This build has reworked item linked chest shops, and added support for custom items.
@OctopusPlaya
I'm looking into it, and in the 2.0.4 build there is an option in the config to turn on experimental support for custom items, The drawback to this is the Citizens API for storing items doesn't store all the item stack data, and when loaded after a restart / reload, the items don't fully match.
I'm thinking through this, and I have some ideas, but time will tell if I can get a proper support for item meta data.
I love this plugin so much! It works flawlessly again on my 1.5.0 server.
I was wondering though, will it ever be possible to sell custom items like renamed or
dyed armor?
@Faldonboy
I didn't test too much over the weekend, but I was able to run cititrader on 1.5. Have you found an issue with cititrader with 1.5?
The most I can think of at this time is I'll have to implement support for the new chest types. Existing functionality shouldn't break though, I haven't done all my test cases yet.
@Twillen
Citizens2 has some stable 1.5 dev builds without many bugs, can we expect an update soonish? Even a dev build would be helpful, this is one of the last plugins stopping me from updating.
I've just uploaded 2.0.4, this will be the last 1.4.7/2.0.7 build, I'll be looking forward to 1.5 and Citizens 2.0.8, unless a bug fix is needed.
@everystat13
Sorry If I'm not understanding you fully, but you can disable and enable specific traders. Each trader has its own buy sell list, unless you link them. So there isn't much reason to implement a enable / disable buy sell option.
I like this plugin a lot, but is there a way of disabling buying / selling per NPC? For instance so you can only buy from an NPC?
I've isolated why named items don't work, and I'll try to wrap my mind around a fix /work around soon.
I have books working, um sort of. They will work until Citizens saves. The item fails to save, and will not be in sell / buy list after reloading.
I'll continue to look into adding these functionality, but they may not be in the next build.
@Lets1Gamer
There is no permission node to allow / deny the use of a trader. It may be tied into the permission of your economy plugin.
Hi
I made some npc shops but non ops cant use them?
What permissions do i need to add?
@fisherman77
Thank you! I like it.