Trade
Trade
Trade with other players!
How to install/use Trade:
Thanks to Skaranova for making this video!
Features:
- Command less trading using right click to request players
- No Spout required
- Very easy to use trading screen
- Customizable messages
- Economy support Since version 0.3
Translations:
You can find translations on this page!
Commands:
Okay, there are a few commands. But they are completely optional.
- /trade <playername> - Requests the named player.
- /trade accept <playername> - Accepts request of named player.
- /trade refuse <playername> - Refuses request of named player.
- /trade ignore - Ignores all incoming requests.
- /trade reload - Reloads the yamls.
Permissions:
See this page!
Configuration:
See this page!
Dependencies:
- Optional:
- Vault if you want to use the economy trading screen
To do list:
- Permission based layout system
- Log/Rollback system
Reporting bugs:
If you found a bug in the plugin please be so kind to file a ticket here. It only takes little time to file one while helping me to keep things organised and fix these bugs quicker.
Known Issues:
Trade was rewritten after version 1.0. Version 1.0 is currently in BETA. It is not completely safe to say the BETA version does not contain any glitches at all but it is safer than any of the previous versions. If you want to use Trade use at least the BETA version"
Development builds:
Development builds of this project can be acquired at the provided continuous integration server. These builds have not been approved by the BukkitDev staff. Use them at your own risk.
https:josvthfoss.ci.cloudbees.com/job/Trade/
Source available on Github
If you like what I'm doing. Consider donating :) Please use the donate button in the top right.
Confirmed. Possible to dupe items with this plugin. Uninstalled until fix.
@LegitCrafter
I'm not quite sure what you mean. Could you file a ticket explaining your problem? Maybe with a youtube video attached to it showing the issue. You can file a ticket here.
There is a glitch... When you trade someone and then they put in an item, and then you refuse the trade and quickly press E (inventory) -> the item is in your inventory even if you refused. I worded this weird but tell me if you don't get anything please.
@josvth
You are welcome. Thanks to you for that really great plugin ;)
@NemesisMate
That is actually a very elegant solution to the problem. Thanks for the idea!
@x_clucky
Wouldn't it be a easy solution to cancel the trade if that's happen?. If one of the players is getting his inventory full and loosing items when they accept the trade, the trade is cancelled instead of accepted and players get a message saying:
Player1: You have too much items to accept the trade.
Player2: Player1 have too much items to accept the trade.
Or even without messages, but letting that items be lost is too many problems for an admin.
@x_clucky
Will this feature be added soon? As much potential as this plugin has, it is a shame to see that there is STILL a bug of this magnitude... It is seriously making me consider removing it alltogether... http://dev.bukkit.org/server-mods/trade/tickets/29-if-inventory-is-full-items-are-lost-enhancement-idea/
Will this plugin be compatible with 1.5 as-is?
Or do you need to release a new verision?
When is this plugin going to be updated to 1.4.7R1.0?
@josvth
I understand there may be no magical fix but the plugin in it's current state is completely unusable, by the word "soon" I was meaning ASAP. Ok, you are looking for a solution to the problem? which you have already stated but I am seeing no progress and it's been a long time since I last posted here. With this bug in your plugin it's just not going to be viable for anyone to use, people have lost items due to this bug, glitch inventories, died thinking they were wearing Armour and the list goes on. Good luck with finding a solution anyway, you must find it as frustrating as I do. The plugin has great potential.
@x_clucky @Sonorpearl
Hooking into LogBlock will not work since it does not have an API to store item changes ( pickups, drops, etc. )
Logging will probably be done using either MySQL storage or logging into a .yml file. And I'll do my best to make a version with this logging as soon as possible.
@OklaMokla
Thank you!
@Waterworth12
It is not as easy as: "Just fix the issue." as I have told you before. I know the issue is rather annoying but for now there is nothing I can do about it.
Please stop nagging me that I should update. Things don't go as magically as you think they go.
Update soon please? This log-out business to fix the bug is really annoying to our users.
nice work!
Do you have done a log yet?
@josvth
Have you started to add this feature yet? You haven't updated the ticket to say so... This feature NEEDS to be added, as not only are player's items lost, but there is no way for an admin to verify that the items were indeed lost... Also, we need transaction history, preferably hooking into logblock... http://dev.bukkit.org/server-mods/trade/tickets/29-if-inventory-is-full-items-are-lost-enhancement-idea/
when i do /trade <playername> accept it says command not found.
@Qwahchees
Is 9 out of 10 just an estimation or have you actually tested it? When I tested after the second time a player Traded his inventory glitches until he re logs.
And yes I've tried the p.updateInventory() and that doesn't fix the problem. The reason lies deeper in CraftBukkit code and is probably also the reason why the updateInventory() method is depreciated.
Hey, just like to inform that 9/10 trades do have an inventory glitch. Would it help to p.updateInventory(); ?
Or has the depreciated? Although I'm pretty sure you've thought of that. What's the issue anyway? I've fiddled with stupid inventory bugs too.