Bukkit

@Empire92

Unfortunately, while the sellall log issue is indeed fixed, the lag/crash problem persists and the player selling it now gets spammed with messages, see the screenshots here: http://imgur.com/a/bvWUh

Also, when attempting to sell damaged durability items using any sell command, the player crashes and no sale is made. I do not think it should be possible to sell damaged stuff but the crash issue must be sold and perhaps have a message added that says you can't sell damaged gear.

I have a bug to report. Sellall can cause major lag and disconnect the player and possibly even crash the server.

I've checked the history file and I believe the issue with sellall at least is that it seems to create huge amounts of duplicate transactions. For example, selling twenty stacks of something creates 20 transaction messages, one for each stack, which are then duplicated 64 times each creating a total of 1280 lines in the history file. Due to the immense lag caused I presume this weirdness is due to the way the sale is handled in the code, not due to a problem in the way the history file works. The issue does not appear with other sell commands from what I can tell.

Hyperconomy does not have any lag issue when selling large quantities so it must be possible to solve this. I suggest as a quick fix until you find a better solution you put in some small delay in the transaction code to slow it down enough to avoid lag. The players will be fine with transactions taking a bit longer to finish if that means they can avoid the crashes and lag and get /sellall (I had to disable it due to the constant player and server crashes).

I'll be happy to send you our history file if it would be of any help.

How do the new signs work by the way? I can't seem to find any info on it.

I've made good progress. Sorry for this wall of text, but this is the most promising market plugin I've ever seen in my years as admin and I'm gonna do whatever I can to help it succeed. By using this formula as a starting point you can have an economy that works in a simple yet sensible and effective way with balanced prices and stocks:

pickanumber/(sold-bought)

This formula makes the price of an item be based on its stock, the lower the stock the higher the price, thus making it more attractive to sell items low in stock which ensures they do not run out. The pick a number is what price your items should have when there is only 1 in stock, this affects what price your items will have at all stock levels.

I highly recommend you also change the default stock to something like this:

default: sold: 100 bought: 0

This gives all items a starting stock and ensure players will not make extreme amounts of money when the plugin is new.

Empire92, for the sake of the success of the plugin, I suggest drawing inspiration from these settings to stop the issues of the default config with its hyperinflation and emptying stocks.

I would also like to report a minor problem, when an item has 0 stock and you sell the first item to it you get an error message and while the item is added to the shop and removed from your inventory, you get no money for the sale. The error message is is "An internal error occurred while attempting to perform this command"

I also have a small feature request. When you type a buy or sell item command but left out the item amount it would be practical if the sale/purchase went through anyway with 1 as default, Hyperconomy uses this system and it's very handy. For example, a crafting table is something you almost always want just 1 of, so you should be able to type /buy craftingtable and you get 1.

Finally, for those like me who prefer to not have adv in front of the commands I've made these aliases for commands.yml and they seem to work well. buy: - advbuy $1 $2 sell: - advsell $1 $2

@McyD1

The default pricing formula does not work, my medium-sized server (30 online during peak hours) has been using it since may 1 and while everything seemed fine during the first few weeks with stocks filling up and prices balancing out, things took a turn for the worse later on. The default pricing formula seems to create steadily-worsening hyperinflation once a certain total number of items have been sold.

The huge amounts of money being generated has made money itself pretty much worthless and gives people incentive to buy useful items for all their money while selling crap to get money for this. Therefore we now have a situation where the stocks of all useful items are always empty while useless crap like dirt is well-stocked and people have millions upon millions of money.

I'm trying to figure out a different formula but I'm no mathematics expert, just a business/economics guy, so it's not easy. I have figured out several ways it could be solved but I simply haven't figured out the math to make them reality yet.

Any luck with enchantments? If you can't find a solution then perhaps you should use the Hyperconomy method of trading the enchantment itself rather than the enchanted book.