qTrade

Table of Contents

This project is abandoned and its default file will likely not work with the most recent version of Minecraft. Whether this project is out of date or its author has marked it as abandoned, this project is no longer maintained.

qTrade - Simple item trading between players

Commands

/trade <player> <item ID/name> <amount> OR /trade <player> $<money> - Sends a trade request
/offer <item ID/name> <amount> OR /offer $<money> - Responds to a trade request with an offer
/tno - Cancels a trade when prompted
/tyes - Accepts an offer, finishes the trade

Permissions

qtrade.trade - Allows a player to send trades
qtrade.receive - Allows a player to receive trades

Features

Very lightweight and easy to use
Fully optional economy support - requires Vault
Logs completed trades, enabled by default
Exploitation-proof
- Trade optionally disabled between worlds and/or players in different game modes
- Checks inventories/balances before completing the trade
Supports all SuperPerms permissions handlers

Comments

_ForgeUser7953222
- Join Date: 11/26/2011
- Posts: 35
- Member Details
#44 _ForgeUser7953222

View User Profile

Send Message

Posted Mar 2, 2013
@XMidnightSunX

As I no longer run a server and this plugin is poorly coded anyway, it was abandoned over a year ago. No bug fixes have been made.

Rollback Post to Revision RollBack
_ForgeUser10579906
- Join Date: 2/16/2013
- Posts: 35
- Member Details
#43 _ForgeUser10579906

View User Profile

Send Message

Posted Mar 2, 2013
Has this been fixed in Comment #42? Because if not, I do not want to download. "if players use negative values in trade/offers, free items and money is made.

example.

/trade user diamond -27 or /trade user $-5

and with

/offer diamond -27

Major duping bug."

Rollback Post to Revision RollBack
ajneumaniii
- Join Date: 1/11/2009
- Posts: 160
- Member Details
#42 ajneumaniii

View User Profile

Send Message

Posted Apr 6, 2012
if players use negative values in trade/offers, free items and money is made.

example.

/trade user diamond -27 or /trade user $-5

and with

/offer diamond -27

Major duping bug.

Rollback Post to Revision RollBack
_ForgeUser7828330
- Join Date: 11/7/2011
- Posts: 1,965
- Member Details
#41 _ForgeUser7828330

View User Profile

Send Message

Posted Apr 5, 2012
@BTYM

Whoa there, I didn't say I was going to rip off your code. Is it even published? I'm not ripping off your idea. I had an idea I came up with on my own, then looked around to see if anybody had already done it. You had almost done it, so I thought that before I cooked my own from zero, I'd see if you'd be willing to improve yours to make it mine. If I were trying to rip you off, I certainly wouldn't have bothered making suggestions to you first. It sounds like you don't care to pursue my ideas, so why shouldn't I pursue them? I'm sorry if I offended you, I probably could have picked better wording there. :)

Last edited by _ForgeUser7828330: Apr 6, 2012

Rollback Post to Revision RollBack
_ForgeUser7953222
- Join Date: 11/26/2011
- Posts: 35
- Member Details
#40 _ForgeUser7953222

View User Profile

Send Message

Posted Apr 3, 2012
@bigscary

Well to be honest, I don't really feel like updating this until there's something that needs attention. It works well as it is.

By the way, coding a ripoff of this is not only rude and insensitive, it's generally a shitty idea to spend time copying someone else's original idea rather than writing your own stuff.

Rollback Post to Revision RollBack
_ForgeUser7828330
- Join Date: 11/7/2011
- Posts: 1,965
- Member Details
#39 _ForgeUser7828330

View User Profile

Send Message

Posted Apr 3, 2012
@BTYM

You haven't said it enough until it's in the description above. :)

Too bad about not changing the commands. Maybe I'll code this after all later. Good to hear though that you'll add a couple of the other suggestions.

Some requests just bloat.

Last edited by _ForgeUser7828330: Apr 3, 2012

Rollback Post to Revision RollBack
_ForgeUser7953222
- Join Date: 11/26/2011
- Posts: 35
- Member Details
#38 _ForgeUser7953222

View User Profile

Send Message

Posted Apr 2, 2012
@bigscary

- EeeeEEEeee how many times must I say this? You don't need to use item IDs!
- The "this" idea is pretty awesome though, I could add that.
- I'm not changing the commands or the name, sorry.
- Distance is a good idea, too. I can add that.
- The qtrade.trade node is for general good style, and the qtrade.receive node was a request. I'm never going to remove something I added on request.

Last edited by _ForgeUser7953222: Apr 2, 2012

Rollback Post to Revision RollBack
_ForgeUser7828330
- Join Date: 11/7/2011
- Posts: 1,965
- Member Details
#37 _ForgeUser7828330

View User Profile

Send Message

Posted Apr 2, 2012
Hi BTYM, I think your plugin would be much easier to use if it followed syntax like the below, and especially didn't require players to use item IDs. I was going to make a plugin to replace yours, but I decided to work on something else. Thanks and good luck!

I'll use friendly names for all materials and allow players to just hold the item in their hand when they don't want to type out the name. Here are some examples.

Giveaway offers:

/offer bigscary 20 dirt

/offer bigscary this

/offer bigscary 20 of this

Trade offers:

/offer bigscary 35 cobblestone for 20 dirt

/offer bigscary 3 diamond for 1000 money

/offer bigscary 3 diamond for 1000 cash

Responses:

/acceptoffer

/declineoffer

/canceloffer

Help:

/offer

The last displays help, reviews any outstanding offer, and provides the name of the item you're holding for the player's future reference.

This more compact syntax is easier to remember and closer to natural English, plus a successful trade only requires one slash command from each player.

Please add an option to require players to be close together, for Vanilla-loving purists out there, and consider renaming it "SecureTrade" to emphasize the value.

I don't see the value in the permissions, since any two players who meet up can just drop items on the ground to trade. It seems to me that taking away their trade slash commands wouldn't do anything other than inconvenience them.

Last edited by _ForgeUser7828330: Apr 2, 2012

Rollback Post to Revision RollBack
_ForgeUser1377611
- Join Date: 10/16/2008
- Posts: 25
- Member Details
#36 _ForgeUser1377611

View User Profile

Send Message

Posted Mar 10, 2012
EDIT: sorry had to enable "Use econ:true" in the config :)

Massen

Last edited by _ForgeUser1377611: Mar 10, 2012

Rollback Post to Revision RollBack
_ForgeUser7953222
- Join Date: 11/26/2011
- Posts: 35
- Member Details
#35 _ForgeUser7953222

View User Profile

Send Message

Posted Mar 8, 2012
@quickclay

Thanks for your crazy polite feedback yo

I'll check all that out tomorrow when I have time, after I split up the monster onCommand method. It's pretty nasty looking and impossible to maintain, there's a slight chance that's why I keep screwing things up...

Last edited by _ForgeUser7953222: Mar 8, 2012

Rollback Post to Revision RollBack
_ForgeUser7459335
- Join Date: 8/28/2011
- Posts: 161
- Member Details
#34 _ForgeUser7459335

View User Profile

Send Message

Posted Mar 7, 2012
Some feedback from our server:
- playernames have to be exact or it fails with no good feedback. either say "player not on" or allow partial names.
- please add /trade help to show syntax and all commands
- players reporting that money trades don't work. /trade playername $amount
-That is all.

Last edited by _ForgeUser7459335: Mar 7, 2012

Rollback Post to Revision RollBack
_ForgeUser7953222
- Join Date: 11/26/2011
- Posts: 35
- Member Details
#33 _ForgeUser7953222

View User Profile

Send Message

Posted Mar 6, 2012
@tmad40blue @Massen

Edited the description to make it a little more clear, the command would be something like:
/trade Loud $50

Thanks for reminding me to change the description ;D

Last edited by _ForgeUser7953222: Mar 6, 2012

Rollback Post to Revision RollBack

_ForgeUser1377611

Join Date: 10/16/2008
Posts: 25
Member Details

#32 Posted Mar 6, 2012

I have the same issue, i for example want to start a trade with 10 money with the player Massen, i type

/trade Massen 10

"invalid imput"

same goes for

/trade Massen money 10 /trade money Massen 10 /trade money 10 massen

19:59:37 [SEVERE] null
org.bukkit.command.CommandException: Unhandled exception executing command 'offe
r' in plugin qTrade v1.3
        at org.bukkit.command.PluginCommand.execute(PluginCommand.java:42)
        at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:16
6)
        at org.bukkit.craftbukkit.CraftServer.dispatchCommand(CraftServer.java:4
61)
        at net.minecraft.server.NetServerHandler.handleCommand(NetServerHandler.
java:818)
        at net.minecraft.server.NetServerHandler.chat(NetServerHandler.java:778)

        at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:761)
        at net.minecraft.server.Packet3Chat.handle(Packet3Chat.java:33)
        at net.minecraft.server.NetworkManager.b(NetworkManager.java:229)
        at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:112)
        at net.minecraft.server.NetworkListenThread.a(NetworkListenThread.java:7
8)
        at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:554)
        at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:452)
        at net.minecraft.server.ThreadServerApplication.run(SourceFile:490)
Caused by: java.lang.NullPointerException
        at btym.qTrade.onCommand(qTrade.java:212)
        at org.bukkit.command.PluginCommand.execute(PluginCommand.java:40)
        ... 12 more

also you cant offer money for a trade it seems I wanted to offer 10 money in a trade, I tested

/offer 10

returns: "Usage: /offer <itemID> <amount>

/offer money 10

returns the above error

Cheers

/Massen

Last edited by _ForgeUser1377611: Mar 6, 2012

_ForgeUser7600475
- Join Date: 9/24/2011
- Posts: 98
- Member Details
#31 _ForgeUser7600475

View User Profile

Send Message

Posted Mar 6, 2012
Could you give us an example of how to trade coins? I cannot figure out the proper syntax - it still thinks I'm offering to trade an item.

Rollback Post to Revision RollBack
_ForgeUser1377611
- Join Date: 10/16/2008
- Posts: 25
- Member Details
#30 _ForgeUser1377611

View User Profile

Send Message

Posted Mar 6, 2012
This looks great :) exactly what I need.

Testing it now!

Massen

Rollback Post to Revision RollBack
_ForgeUser7953222
- Join Date: 11/26/2011
- Posts: 35
- Member Details
#29 _ForgeUser7953222

View User Profile

Send Message

Posted Mar 4, 2012
(And by tomorrow, I mean in 20 days)

v1.3.3 uploaded, fixed some bugs.

Rollback Post to Revision RollBack
_ForgeUser7953222
- Join Date: 11/26/2011
- Posts: 35
- Member Details
#28 _ForgeUser7953222

View User Profile

Send Message

Posted Feb 12, 2012
@funkystudios

Welp, I knew that update was bound to break something. Whoops. I can fix it tomorrow.

Rollback Post to Revision RollBack
_ForgeUser7792607
- Join Date: 10/31/2011
- Posts: 141
- Member Details
#27 _ForgeUser7792607

View User Profile

Send Message

Posted Feb 11, 2012
The plugin freaks out when the player you offered to trade with is offline. I would love to see a custom error message instead of a bukkit error message "An internal error occurred when.....". Might confuse people.

Heres the error my server log gave me: http://pastebin.com/Jgrp0zrf

Rollback Post to Revision RollBack
_ForgeUser7953222
- Join Date: 11/26/2011
- Posts: 35
- Member Details
#26 _ForgeUser7953222

View User Profile

Send Message

Posted Feb 5, 2012
@Switch0r

Maybe, when I have time

Rollback Post to Revision RollBack
_ForgeUser6898239
- Join Date: 5/26/2011
- Posts: 323
- Member Details
#25 _ForgeUser6898239

View User Profile

Send Message

Posted Feb 5, 2012
Can you make so they can only use it in a certain area (in a shop or a region) ?
Also give the shop owner a percentage x% of the money if they trade.

I know i ask to much but they are just some ideas.

Rollback Post to Revision RollBack
To post a comment, please login or register a new account.

Project ID

35340
Created

Jan 2, 2012
Last Released File

Mar 4, 2012
Total Downloads

2,792
License

GNU General Public License ver...

Bukkit

qTrade

Bukkit Plugins

qTrade

Table of Contents

qTrade - Simple item trading between players

Commands

Permissions

Features

Comments

About This Project

Categories

Members

Recent Files

Bukkit