qTrade - Simple item trading between players
/trade <player> <item ID/name> <amount> OR /trade <player> $<money> - Sends a trade request
/offer <item ID/name> <amount> OR /offer $<money> - Responds to a trade request with an offer
/tno - Cancels a trade when prompted
/tyes - Accepts an offer, finishes the trade
qtrade.trade - Allows a player to send trades
qtrade.receive - Allows a player to receive trades
- Very lightweight and easy to use
- Fully optional economy support - requires Vault
- Logs completed trades, enabled by default
- Trade optionally disabled between worlds and/or players in different game modes
- Checks inventories/balances before completing the trade
- Supports all SuperPerms permissions handlers
As I no longer run a server and this plugin is poorly coded anyway, it was abandoned over a year ago. No bug fixes have been made.
Has this been fixed in Comment #42? Because if not, I do not want to download. "if players use negative values in trade/offers, free items and money is made.
/trade user diamond -27 or /trade user $-5
/offer diamond -27
Major duping bug."
if players use negative values in trade/offers, free items and money is made.
/trade user diamond -27 or /trade user $-5
/offer diamond -27
Major duping bug.
Whoa there, I didn't say I was going to rip off your code. Is it even published? I'm not ripping off your idea. I had an idea I came up with on my own, then looked around to see if anybody had already done it. You had almost done it, so I thought that before I cooked my own from zero, I'd see if you'd be willing to improve yours to make it mine. If I were trying to rip you off, I certainly wouldn't have bothered making suggestions to you first. It sounds like you don't care to pursue my ideas, so why shouldn't I pursue them? I'm sorry if I offended you, I probably could have picked better wording there. :)
Well to be honest, I don't really feel like updating this until there's something that needs attention. It works well as it is.
By the way, coding a ripoff of this is not only rude and insensitive, it's generally a shitty idea to spend time copying someone else's original idea rather than writing your own stuff.
You haven't said it enough until it's in the description above. :)
Too bad about not changing the commands. Maybe I'll code this after all later. Good to hear though that you'll add a couple of the other suggestions.
Some requests just bloat.
- EeeeEEEeee how many times must I say this? You don't need to use item IDs!
- The "this" idea is pretty awesome though, I could add that.
- I'm not changing the commands or the name, sorry.
- Distance is a good idea, too. I can add that.
- The qtrade.trade node is for general good style, and the qtrade.receive node was a request. I'm never going to remove something I added on request.
Hi BTYM, I think your plugin would be much easier to use if it followed syntax like the below, and especially didn't require players to use item IDs. I was going to make a plugin to replace yours, but I decided to work on something else. Thanks and good luck!
I'll use friendly names for all materials and allow players to just hold the item in their hand when they don't want to type out the name. Here are some examples.
/offer bigscary 20 dirt
/offer bigscary this
/offer bigscary 20 of this
/offer bigscary 35 cobblestone for 20 dirt
/offer bigscary 3 diamond for 1000 money
/offer bigscary 3 diamond for 1000 cash
The last displays help, reviews any outstanding offer, and provides the name of the item you're holding for the player's future reference.
This more compact syntax is easier to remember and closer to natural English, plus a successful trade only requires one slash command from each player.
Please add an option to require players to be close together, for Vanilla-loving purists out there, and consider renaming it "SecureTrade" to emphasize the value.
I don't see the value in the permissions, since any two players who meet up can just drop items on the ground to trade. It seems to me that taking away their trade slash commands wouldn't do anything other than inconvenience them.
EDIT: sorry had to enable "Use econ:true" in the config :)
Thanks for your crazy polite feedback yo
I'll check all that out tomorrow when I have time, after I split up the monster onCommand method. It's pretty nasty looking and impossible to maintain, there's a slight chance that's why I keep screwing things up...
Some feedback from our server:
- playernames have to be exact or it fails with no good feedback. either say "player not on" or allow partial names.
- please add /trade help to show syntax and all commands
- players reporting that money trades don't work. /trade playername $amount
-That is all.
Edited the description to make it a little more clear, the command would be something like:
/trade Loud $50
Thanks for reminding me to change the description ;D
I have the same issue, i for example want to start a trade with 10 money with the player Massen, i type
/trade Massen 10
same goes for
/trade Massen money 10 /trade money Massen 10 /trade money 10 massen
also you cant offer money for a trade it seems I wanted to offer 10 money in a trade, I tested
returns: "Usage: /offer <itemID> <amount>
/offer money 10
returns the above error
Could you give us an example of how to trade coins? I cannot figure out the proper syntax - it still thinks I'm offering to trade an item.
This looks great :) exactly what I need.
Testing it now!
(And by tomorrow, I mean in 20 days)
v1.3.3 uploaded, fixed some bugs.
Welp, I knew that update was bound to break something. Whoops. I can fix it tomorrow.
The plugin freaks out when the player you offered to trade with is offline. I would love to see a custom error message instead of a bukkit error message "An internal error occurred when.....". Might confuse people.
Heres the error my server log gave me: http://pastebin.com/Jgrp0zrf
Maybe, when I have time
Can you make so they can only use it in a certain area (in a shop or a region) ?
Also give the shop owner a percentage x% of the money if they trade.
I know i ask to much but they are just some ideas.