GroupManager, Sub Group Bug #447


  • Defect
  • Waiting
Open
Assigned to _ForgeUser8455416
  • _ForgeUser10851183 created this issue Mar 21, 2014

    I am using Essentials group manager to handle player permissions.
    I sell VIP packages through donation points. This plugins enables me  to sell VIP permissions automaticly. If the user has enough balance he can go click a sign and be promoted to the group VIP.

    Here is my detailed rewads.yml as it is relevant: http://pastebin.com/9VjuLmm1

    Say that a player SAXONS12 has 15 days of ontime. So he is a ProMember in my server ( > 10days). Then he goes to buy UltraVIP and is promoted to that group. After the package time is over the DonationPoints plugin executes a expire command which is "/manuadd player Member". So know SAXONS12 is a Member as his VIP time is over. He waits 2minutes in game and is promoted to the TrustedMember group ( ontime > 4days 4h). He waits a couple minutes more but he is than removed from the group TrustedMember and is added to the sub group ProMember (> 10d).

    The problem here is ontime somehow changes users sup group. It uses something like /manuaddsub player ProMember. This causes the user to have all necessary permissions but a missing blank tag.

    This problem does not accur every time, not does it only accur in a particulur case, sometimes users are added to the sub group of TrustedMember.

    But kaya947 here is an example (same situation explained above): http://pastebin.com/ksmc5aVn (not mentioned in ontime error logs)

    Thanks for your support!

  • _ForgeUser10851183 added the tags New Defect Mar 21, 2014
  • _ForgeUser8455416 posted a comment Mar 22, 2014

    Hi Saxons,

    I think I follow, but I'm not seeing the problem. Looking at your example with kaya947, it seems that they go through the right set of promotions to get them back to the group where they belong. (ProMember).

    OnTime does not use any 'sub' group functions.

    Is the issue that the player is now a member to more than one group? TrustedMember and ProMember?

    Maybe what I need to see is the resulting configuration from groupManager for players like kaya947, to better understand.

    BTW. I got a kick out your rewards.yml since has components that are so old, that I know you are truly one of the oldest, dedicated users of the plugin. And if you want to clean it up just a little bit, if you edit and remove the "testKit" line from under the 'kits:" keyword, and then remove those last three rewards, they won't come back.


    Edited Mar 22, 2014
  • _ForgeUser8455416 removed a tag New Mar 22, 2014
  • _ForgeUser8455416 added a tag Waiting Mar 22, 2014
  • _ForgeUser10851183 posted a comment Mar 24, 2014

    Well after they are promoted to the group they belong this happens:

    User: kaya947
    Group: Default
    SubGroup: ProMember

    in the groupmanager ymls. This might also be a bug with groupmanager, maybe it can't handle promotions so fast (idk).

    What if th user was removed from TrustedMember group and than added to the ProMember group after couple of minutes. It is probably about the commands conflicting.
    Should I also contact groupmanager ?

    Ok I will regenerate files, thank you for you help :)

  • _ForgeUser8455416 posted a comment Mar 31, 2014

    @saxons12: Go

    What version of GroupManager and Vault are you using? I'd like to run some more tests before I tell you to go bug the groupmanager team. I may also be able to tell you some info to share with them if its possible it is a problem at their end.

  • _ForgeUser8455416 removed a tag Replied Mar 31, 2014
  • _ForgeUser8455416 added a tag Waiting Mar 31, 2014
  • _ForgeUser10851183 posted a comment Apr 4, 2014

    Group manager      #2.0.137
    and Vault 1.2.31

    ok I am waiting.

  • _ForgeUser10851183 removed a tag Waiting Apr 4, 2014
  • _ForgeUser10851183 added a tag Replied Apr 4, 2014
  • _ForgeUser8455416 posted a comment Apr 13, 2014

    Sorry for the long delay. I have been out of town again for work.

    I tried to reproduce your problem but can't. Each promotion using the GM and Vault versions you have is yielding the correct result. (Group change, but no change to sub-groups)

    Can you share a link to your GM "groups.yml" file. Because I don't have inheritance set up etc. in my test, maybe the answer lies in your exact GM setup.

  • _ForgeUser8455416 removed a tag Replied Apr 13, 2014
  • _ForgeUser8455416 added a tag Waiting Apr 13, 2014
  • _ForgeUser10851183 posted a comment Apr 15, 2014

    I have sent you the file over PM.

  • _ForgeUser10851183 removed a tag Waiting Apr 15, 2014
  • _ForgeUser10851183 added a tag Replied Apr 15, 2014
  • _ForgeUser8455416 posted a comment Apr 15, 2014

    @saxons12: Go

    I still cannot reproduce the problem, even with your full groups.yml file.

    Regarding your theory that OnTime may be too fast changing groups, I don't think this is the issue because it is running on a single thread where it won't attempt the "add" of the new group until after it knows the result of removing the old group. There are no error messages in the OnTimeLog.txt that indicates there was any error in removing the old group, so I think this is a dead end.

    Can you look to see if you have an OnTimeERROR.txt file, and if so post a link to a copy of that file. That is another place to look for errors with the interaction with GM.

    Also, once your other plugin executes the "manuadd" command to put them in the Member group, OnTime will have no idea that the player's group has changed. You say it figures this out after 2 min, but it really should not be detected until the player logs out and logs back in again. (Unless there is some other event like an 'ontime reload' that forces OnTime to re-evaluate all player's reward status.)

  • _ForgeUser8455416 removed a tag Replied Apr 15, 2014
  • _ForgeUser8455416 added a tag Waiting Apr 15, 2014

To post a comment, please login or register a new account.