Mailbox ignores PEX restrictions #13


  • Defect
  • Replied
Open
Assigned to _ForgeUser6874375
  • _ForgeUser10431075 created this issue Jan 31, 2013

    What steps will reproduce the problem?
    1.add - -mailbox.* to permissions.yml.
    2.reboot server

    What is the expected output? What do you see instead?
    I expect players to be prevented from using any mailbox commands.  Instead, all mailbox commands are wide open and usable by players, rather than being prevented.

    What version of the product are you using?
    CB 1.4.7R1.0
    Mailbox 2.6

    Do you have an error log of what happened?
    pex debug:
    2013-01-31 15:04:56 [INFO] xxxplayerxxx issued server command: /mailbox send xxxplayerxxx
    2013-01-31 15:04:56 [INFO] User xxxplayerxxx checked for "mailbox.user.send", "-mailbox.*" found
    2013-01-31 15:04:56 [INFO] User xxxplayerxxx checked for "mailbox.sendtoself", "-mailbox.*" found
    2013-01-31 15:04:56 [INFO] User xxxplayerxxx checked for "mailbox.nocooldown", "-mailbox.*" found
    2013-01-31 15:04:56 [INFO] MailBox: xxxplayerxxx has sent the package to xxxplayerxxx. [WOOL:1]

    Please provide any additional information below.

  • _ForgeUser10431075 added the tags New Defect Jan 31, 2013
  • _ForgeUser6874375 unassigned issue from _ForgeUser4967307 Feb 1, 2013
  • _ForgeUser6874375 self-assigned this issue Feb 1, 2013
  • _ForgeUser6874375 posted a comment Feb 1, 2013

    In PEX, you must negate permissions first in the list.
    for example

    - -mailbox.*
    - somepermission.node
    - otherpermission.node
    


    This would not work:

    - somepermission.node
    - -mailbox.*
    


    Also make sure you are not testing as op or with - '*'

  • _ForgeUser6874375 removed a tag New Feb 1, 2013
  • _ForgeUser6874375 added a tag Waiting Feb 1, 2013
  • _ForgeUser10431075 posted a comment Feb 1, 2013

    Thank you for your attention, For testing purposes, the only PEX entry regarding mailbox is the complete restriction: - -mailbox.* there are no allowances for mailbox. I am not in OP mode or with - '*'. The pex debug quoted above shows that -mailbox.* was found, yet mailbox continued to function. If it matters, mailbox is operating with SQL backend.

    Edit:There are unrelated permissions/restrictions ahead of this in the pex list. Are you saying that - -mailbox.* has to be the very first entry in pex? If so I'll try that tonight. Thank you again fro your attention.


    Edited Feb 1, 2013
  • _ForgeUser10431075 removed a tag Waiting Feb 1, 2013
  • _ForgeUser10431075 added a tag Replied Feb 1, 2013
  • _ForgeUser6874375 posted a comment Feb 1, 2013

    @misterbiskits: Go

    As I understand it, negated permissions have to come before any others in a list in PEX, otherwise they wont work. I can't really support PEX properly because it does not play by the rules.

  • _ForgeUser10431075 posted a comment Feb 2, 2013

    @Iaccidentally: Go

    OK, here is a test world with only PEX and MailBox 2.5 installed. 1 player is defined, belonging to 1 group. 1 restriction is defined for the group. -mailbox.* it is the only entry in the pex yml so we don't have to worry about whether its first or last. Because -mailbox.* is stated, xxxplayerxxx shouldn't be able to do anything at all. Pex finds the restriction, MailBox goes ahead and creates a mailbox anyway.

    20:47:39 [INFO] Starting minecraft server version 1.4.7
    20:47:39 [INFO] Loading properties
    20:47:39 [INFO] Default game type: SURVIVAL
    20:47:39 [INFO] Generating keypair
    20:47:39 [INFO] Starting Minecraft server on *:25565
    20:47:39 [INFO] This server is running CraftBukkit version git-Bukkit-1.4.7-R1.0-b2624jnks (MC: 1.4.7) (Implementing API version 1.4.7-R1.0)
    20:47:40 [INFO] [PermissionsEx] sql backend registered!
    20:47:40 [INFO] [PermissionsEx] file backend registered!
    20:47:40 [INFO] [PermissionsEx] PermissionEx plugin initialized.
    20:47:40 [INFO] [PermissionsEx] Loading PermissionsEx v1.19.5
    20:47:40 [INFO] [PermissionsEx] Initializing file backend
    20:47:40 [INFO] Permissions file successfully reloaded
    20:47:40 [INFO] [MailBox] Loading MailBox v2.5
    20:47:40 [INFO] Preparing level "world"
    20:47:40 [INFO] Preparing start region for level 0 (Seed: -2475853393463438826)
    20:47:41 [INFO] Preparing spawn area: 97%
    20:47:41 [INFO] Preparing start region for level 1 (Seed: -2475853393463438826)
    20:47:42 [INFO] Preparing start region for level 2 (Seed: -2475853393463438826)
    20:47:42 [INFO] [PermissionsEx] Enabling PermissionsEx v1.19.5
    20:47:42 [INFO] [PermissionsEx] Superperms support enabled.
    20:47:42 [INFO] [PermissionsEx] v1.19.5 enabled
    20:47:42 [INFO] [MailBox] Enabling MailBox v2.5
    20:47:42 [INFO] [MailBox] New thread running.
    20:47:42 [INFO] [MailBox] Economy plugin not found.
    20:47:43 [INFO] [MailBox]: (web-response): Plugin is up to date.
    20:47:43 [INFO] MailBox version 2.5 is enabled! (MySQL is disabled.)
    20:47:43 [INFO] Server permissions file permissions.yml is empty, ignoring it
    20:47:43 [INFO] Done (3.407s)! For help, type "help" or "?"
    >pex group Players user add xxxplayerxxx
    20:49:12 [INFO] User xxxplayerxxx added to Players !
    >pex group Players add -mailbox.*
    20:49:19 [INFO] Permission "-mailbox.*" added to Players !
    20:49:39 [INFO] xxxplayerxxx[/216.211.83.16:60142] logged in with entity id 269 at ([world] -106.5, 66.62000000476837, 251.5)
    >pex toggle debug
    20:49:52 [WARNING] [PermissionsEx] Debug mode enabled
    20:50:46 [INFO] xxxplayerxxx issued server command: /mailbox create
    20:50:46 [INFO] User xxxplayerxxx checked for "mailbox.user.create", "-mailbox.*" found
    20:50:47 [INFO] MailBox: xxxplayerxxx has created the mailbox for xxxplayerxxx. [-85;64;251]
    20:50:50 [INFO] Connection reset
    20:50:50 [INFO] xxxplayerxxx lost connection: disconnect.quitting
    >pex users list
    20:52:41 [INFO] [PermissionsEx] User xxxplayerxxx initialized
    20:52:41 [INFO] Currently registered users:
    20:52:41 [INFO]  xxxplayerxxx [Players]
    >pex user xxxplayerxxx
    20:53:28 [INFO] xxxplayerxxx are member of:
    20:53:28 [INFO]    Players (not ranked)
    20:53:28 [INFO] xxxplayerxxx's permissions:
    20:53:28 [INFO]    -mailbox.* (from Players)
    20:53:28 [INFO] xxxplayerxxx's options:
    

    Edited Feb 3, 2013
  • _ForgeUser10431075 posted a comment Feb 4, 2013

    I tried it without pex.  New server with only mailbox installed.  I hoped that by editing the default values in plugin.yml I could get it working.
    No dice.  Changing the Default: values from 'true' to 'false' has no effect.  Changing from 'op' to 'true' or 'false' appears to work though.
    The problem is not pex.  I'm sorry.  This is a great idea and the kids would enjoy the plugin.  Please look into it further if you are inclined.
    Have a nice day.

  • _ForgeUser6835820 posted a comment Feb 18, 2013

    We're having the same issues. Even with the nodes negated, anyone has access to create mailboxes.

    This is clearly a bug in the plugin, not in PEX, as it's working fine for all the other plugins with permissions we're running.

    We use PEX MyQSL btw, not flatfile.

    Ideally, this plugin would just support/use Vault, that would likely solve these issues.


    Edited Feb 20, 2013

To post a comment, please login or register a new account.