Bukkit

I've been using this plugin for a few days now on spigot 1.8 and we're really enjoying it. I do have some concerns though, which has led me to create my own plugin similar to this. I felt I should mention my concerns to you.

Firstly, there is a huge exploit for the ores that drop the ore block item (iron and gold) because you dont need silk touch for these. Just simply break them, replace them, rinse and repeat for as many chances/items you want.

That leads me to my second concern. There is currently no way to specify certain items (or chances of items) to certain ores. Its either all items have chance on all items, or nothing at all. This is troublesome because people mining coal/iron have the same chances of receiving the same lucky items as diamond/emerald. Not to mention the exploit on iron/gold can be easily minimized by putting crap odds and/or crap items on them leaving the good items/odds on the other ores.

Third, your implementation of redstone will never result in a drop. You use REDSTONE_ORE, which technically isn't the block that player's break. Redstone actualy glows when you touch it, turning it into GLOWING_REDSTONE_ORE. My plugin simply checks for both of these just in case of oddities.

Next, the configuration file resets if anything was found wrong with it. Total bummer... I have co-operators on my server and someone today missed a single space after a colon and after reloading the plugin the entire config reset to default instead of just gracefully throwing an error. Totally sucked because I had about 20 lucky items and had to retype the whole thing up again from memory due to not having a backup of it.

Lastly, your random number generator is creating a new seed each roll, which means some uniformity is lost in the calculations. You can make your Random() as a static field instead, or simply use Math.random() which is already static and pretty much the same thing as rand.nextDouble(). To be honest, the way you store and calculate chance altogther seems over the top and very hard to follow/read. Jumping between 3 classes (not counting the multiple SusperStack instances) just to calculate a single chance.. *whew* With all that said, the way you have it seems to work, so consider this one just my simple opinion :p

All things considered, this is a decent plugin still. Just has some loose ends to tie up to become rock solid, imo. ^_^