Bukkit

@CMahaff

Awesome, glad to be of help! I'm self-learning too, but quite a bit behind you... Converting old plugins to the new event and config systems and making other similar small changes is the extent of my abilities right now. :)

Can't wait to see if the fix helps!

@Darkhand81

Oh okay. Well let me know how it turns out :) Just from experience, you may need to "prune" your tree a bit as they tend to come out a bit square as you increase the size.

But this is interesting: "The concurrent collector will throw an OutOfMemoryError if too much time is being spent in garbage collection." Looking at my code I see I'm creating a local variable type Block and Material each loop through. I imagine if this runs repeatedly very quickly it might not be able to garbage collect fast enough and you'd get your error. It explains why slowing it down works too. Relevant source if you are interested/a programmer: https://github.com/CMahaff/Giant-Trees/blob/master/src/com/connormahaffey/GiantTrees/TreeBuilder.java

Very simple fix, very dumb mistake. I am a self-learner and I hadn't really learned a whole lot about memory management going into this. I can have a fix up tomorrow, will take 10 seconds. I can't guarantee it will fix the problem but it might. Thanks for letting me know and being so helpful :)

@CMahaff

That's a lot of garbage cleanup :)

I'm actually only needing a single gigantic tree, to carve a town into. :) I'm going to let the build-delayed tree run overnight and see how it goes... I'm not running completely out of memory, but hitting the garbage collection overhead limit... Here's Sun's take on it:

"The concurrent collector will throw an OutOfMemoryError if too much time is being spent in garbage collection: if more than 98% of the total time is spent in garbage collection and less than 2% of the heap is recovered, an OutOfMemoryError will be thrown. This feature is designed to prevent applications from running for an extended period of time while making little or no progress because the heap is too small. If necessary, this feature can be disabled by adding the option -XX:-UseGCOverheadLimit to the command line."

Since I only need the one ginormous tree, I'll also try running the server with that command line argument during 'build time' and see how it goes.

@Darkhand81

It's a possibility. Again, it probably won't be fixed until I port the plugin to the new Minecraft Official API that is on the horizon. I'm sorry, but it just wouldn't be worth it. About the time I'd have re-written it, it would come out.

And to be honest, I never really planned for trees that big! I mean, when I made the plugin, the largest tree from ground level was like 60 blocks top. The new world height is a whole other beast.

I'm sorry you're having problems though. Since changing the build speed affects the outcome, I have to wonder if Bukkit is at fault and not my plugin. Or maybe if Garbage Collection just isn't fast enough at full speed....

If you REALLY want I could send you a build with force garbage collection at the end of every build loop, but, um, Bukkit may explode. Just a warning. But it's something we could try.

@CMahaff

4 gigs; I get to about the last 50% of the canopy and lose it.

Setting the build delay to 1 or 2 makes a huge difference... the server seems to be holding up well so far, but it's also going to take hours to build one tree. Would a hybrid system work? i.e., build at full speed for a few dozen ticks, take a break, repeat.

@Darkhand81

Well because this plugin has to load thousands of blocks into memory at once, it is and always will be an issue. It's really not anything I can fix without an entire re-code :/ and even then, it would still use a lot of memory.

I don't think anything is up, just keeping track 10,000 blocks is very hard on the server.

Maybe when the new Minecraft API comes out I can try and make it better for the port, maybe by loading the blocks in slowly and building the tree in parts. As it is now, it grabs all the blocks that will be the outline of the tree and changes them in one go. That takes massive amounts of memory.

Just out of curiosity, how much memory does your server have?

Any manually made large trees (96, 128, anything that seems to go over the old 128 height limit, though I haven't confirmed that yet) is failing with:

[SEVERE] Unexpected exception java.lang.OutOfMemoryError: GC overhead limit exceeded

Just to see if I can finish one tree I may try disabling the garbage collection overhead limit option in Java as a workaround, but something's up!

@darkcloud784

Well that's a problem, values don't work well with permissions. If I did it like that I'd literally have to check every single possible value:

If(player.hasPermission(gt.35)){} If(player.hasPermission(gt.36)){} If(player.hasPermission(gt.37)){} If(player.hasPermission(gt.38)){} etc...

But you can set limits height/width in your config file: https://github.com/CMahaff/Giant-Trees/wiki/Settings

Then, as admin, just give yourself the gianttrees.nolimit permission so you, personally, can make them as big as you want.

@darkcloud784

Well its tough because it has to load all those blocks into memory. There really isn't much I can do. A possibility would have been to make different parts separately, but it's too late to change that in the code now. I know this plugin is quite resource intensive. Maybe I can make it better when the Minecraft Mod API comes out.

@darkcloud784

It should support jungle type by using "jungle" where you'd normally use "birch", etc.

So yes :)

@darkcloud784

Did you get any errors?

@darkcloud784

It may take some time for it to complete the undo. How long did you wait?

@Galexrt

Should work fine with 1.2.3. Plugins do not need to be updated every build unless something breaks - and nothing should have. In fact, I already coded in jungle support when I released for 1.1.

Enjoy.