Bukkit

Almost every time or every time (not sure) a player breaks any sign on my server, I get the following error in the log. This has been happening in both 1.43 and 1.44.

22:38:28 [SEVERE] Could not pass event BLOCK_BREAK to DynamicShop
java.lang.NullPointerException
    at me.zylinder.dynamicshop.SignHandler.getSignOwnerPlayer(SignHandler.java:219)
    at me.zylinder.dynamicshop.DynamicShopBlockListener.onBlockBreak(DynamicShopBlockListener.java:173)
    at org.bukkit.plugin.java.JavaPluginLoader$40.execute(JavaPluginLoader.java:539)
    at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:58)
    at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:339)
    at net.minecraft.server.ItemInWorldManager.c(ItemInWorldManager.java:201)
    at net.minecraft.server.ItemInWorldManager.dig(ItemInWorldManager.java:98)
    at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:498)
    at org.getspout.spout.SpoutNetServerHandler.a(SpoutNetServerHandler.java:208)
    at net.minecraft.server.Packet14BlockDig.a(SourceFile:43)
    at net.minecraft.server.NetworkManager.b(NetworkManager.java:226)
    at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:93)
    at org.getspout.spout.SpoutNetServerHandler.a(SpoutNetServerHandler.java:550)
    at net.minecraft.server.NetworkListenThread.a(SourceFile:108)
    at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:527)
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:425)
    at net.minecraft.server.ThreadServerApplication.run(SourceFile:457)

Everything else appears to be working without any problems and this doesn't effect the functionality as I don't use player to player signs. However, I expect it would stop users regaining items after a player trade sign was broken as the plugin doesn't know that the sign was broken.

Was the sign owner online? Also try it out with new created signs, pls.

@SchwarzerZylinder: Go

Did a bit of testing, the error occurs with any sign that is placed on the ground but not with signs that are placed on walls. It does not matter if the sign is blank or not.

Haven't tested with actual player shop signs as I don't use them. I'd imagine the same would occur.

Seems like the position isn't saved properly...

@SchwarzerZylinder: Go

I wouldn't have thought that the position should be saved at all by this plugin if the sign is completely blank?

@Mako_Shark: Go

If you place a sign wrong, it should normally drop instantly and show you the error...

@SchwarzerZylinder: Go

I don't mean a sign that has some text on it related to your plugin, (e.g [dynshop]). I am talking about a sign that has no text on at all - it is 100% blank.

I had a look at the source code, the request if a sign is a DynamicShop sign isn't working. Will fix it.

@SchwarzerZylinder: Go

Thanks. I will be testing out your CityGuard plugin soon. It is a great idea for player protection in towns.