Healing item frames errors out and spams console #158


  • New
  • Defect
Open
Assigned to Drexplosionpd
  • Jikoo_K created this issue Dec 14, 2014

    What steps will reproduce the problem?
    Not 100% certain, based on the error I'd guess that a block with an item frame attached was burned and healed.

    What version of the product are you using?
    CreeperHeal v6.7.9 on Spigot 1.8 git-Spigot-612de46-07c2162

    Do you have an error log of what happened?

    [16:50:22] [Server thread/WARN]: [CreeperHeal] Task #1590 for CreeperHeal v6.7.9 generated an exception
    java.lang.NullPointerException
            at org.bukkit.craftbukkit.v1_8_R1.CraftWorld.spawn(CraftWorld.java:1033) ~[spigot.jar:git-Spigot-612de46-07c2162]
            at org.bukkit.craftbukkit.v1_8_R1.CraftWorld.spawn(CraftWorld.java:836) ~[spigot.jar:git-Spigot-612de46-07c2162]
            at com.nitnelave.CreeperHeal.block.CreeperItemFrame.replace(CreeperItemFrame.java:58) ~[?:?]
            at com.nitnelave.CreeperHeal.block.CreeperBurntBlock.replace(CreeperBurntBlock.java:71) ~[?:?]
            at com.nitnelave.CreeperHeal.block.CreeperBurntBlock.checkReplace(CreeperBurntBlock.java:177) ~[?:?]
            at com.nitnelave.CreeperHeal.block.BurntBlockManager.replaceBurnt(BurntBlockManager.java:133) ~[?:?]
            at com.nitnelave.CreeperHeal.block.BurntBlockManager.access$1(BurntBlockManager.java:124) ~[?:?]
            at com.nitnelave.CreeperHeal.block.BurntBlockManager$2.run(BurntBlockManager.java:66) ~[?:?]
            at org.bukkit.craftbukkit.v1_8_R1.scheduler.CraftTask.run(CraftTask.java:71) ~[spigot.jar:git-Spigot-612de46-07c2162]
            at org.bukkit.craftbukkit.v1_8_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:350) [spigot.jar:git-Spigot-612de46-07c2162]
            at net.minecraft.server.v1_8_R1.MinecraftServer.z(MinecraftServer.java:694) [spigot.jar:git-Spigot-612de46-07c2162]
            at net.minecraft.server.v1_8_R1.DedicatedServer.z(DedicatedServer.java:316) [spigot.jar:git-Spigot-612de46-07c2162]
            at net.minecraft.server.v1_8_R1.MinecraftServer.y(MinecraftServer.java:623) [spigot.jar:git-Spigot-612de46-07c2162]
            at net.minecraft.server.v1_8_R1.MinecraftServer.run(MinecraftServer.java:526) [spigot.jar:git-Spigot-612de46-07c2162]
            at java.lang.Thread.run(Thread.java:745) [?:1.8.0_11]
    

    This error occurs once per second when CreeperHeal attempts to heal the relevant object.

  • Jikoo_K added the tags New Defect Dec 14, 2014
  • Jikoo_K edited description Dec 14, 2014
  • Drexplosionpd posted a comment Dec 14, 2014

    thanks for posting, ill see what i can do about it.


    Edited Dec 14, 2014
  • Drexplosionpd unassigned issue from nitnelave Dec 14, 2014
  • Drexplosionpd self-assigned this issue Dec 14, 2014
  • Jikoo_K posted a comment Dec 15, 2014

    Likely to have been caused by https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/commits/01f0122a9e4ab863595a39ca4dca342f10dcc477

    Reverses the direction to find the block to heal in, from my understanding.

  • Jikoo_K posted a comment Dec 16, 2014

    Looking at the open issues in Spigot's bug tracker, this may not be worth trying to fix for the near future - looks like item frames have some other issues that still need to be fixed, so more changes could be coming.

  • Drexplosionpd posted a comment Dec 16, 2014

    @Jikoo_K: Go

    ok thanks!

  • Jikoo_K posted a comment Dec 23, 2014

    Looks like all the itemframe changes are probably complete, please consider this issue re-opened. I'll try to reproduce it on a test server when I have the time, but I suspect that this can be replicated by burning a block with an item frame on it and air on the opposite side, then waiting for it to heal.

  • Jikoo_K posted a comment Mar 3, 2015

    This is still a problem. I can replicate it reliably by burning a block with an item frame attached. When it heals, the item frame and content are dropped every heal interval, leading to a dupe bug. When I log out, unloading the chunk, that NPE starts occurring every heal interval.

    [11:21:31] [Server thread/WARN]: [CreeperHeal] Task #14 for CreeperHeal v6.7.2 generated an exception
    java.lang.NullPointerException
            at org.bukkit.craftbukkit.v1_8_R1.CraftWorld.spawn(CraftWorld.java:1058) ~[spigot.jar:git-Spigot-c3c767f-33d5de3]
            at org.bukkit.craftbukkit.v1_8_R1.CraftWorld.spawn(CraftWorld.java:837) ~[spigot.jar:git-Spigot-c3c767f-33d5de3]
            at com.nitnelave.CreeperHeal.block.CreeperItemFrame.replace(CreeperItemFrame.java:58) ~[?:?]
            at com.nitnelave.CreeperHeal.block.CreeperBurntBlock.replace(CreeperBurntBlock.java:71) ~[?:?]
            at com.nitnelave.CreeperHeal.block.CreeperBurntBlock.checkReplace(CreeperBurntBlock.java:177) ~[?:?]
            at com.nitnelave.CreeperHeal.block.BurntBlockManager.replaceBurnt(BurntBlockManager.java:133) ~[?:?]
            at com.nitnelave.CreeperHeal.block.BurntBlockManager.access$100(BurntBlockManager.java:27) ~[?:?]
            at com.nitnelave.CreeperHeal.block.BurntBlockManager$2.run(BurntBlockManager.java:66) ~[?:?]
            at org.bukkit.craftbukkit.v1_8_R1.scheduler.CraftTask.run(CraftTask.java:71) ~[spigot.jar:git-Spigot-c3c767f-33d5de3]
            at org.bukkit.craftbukkit.v1_8_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:350) [spigot.jar:git-Spigot-c3c767f-33d5de3]
            at net.minecraft.server.v1_8_R1.MinecraftServer.z(MinecraftServer.java:709) [spigot.jar:git-Spigot-c3c767f-33d5de3]
            at net.minecraft.server.v1_8_R1.DedicatedServer.z(DedicatedServer.java:316) [spigot.jar:git-Spigot-c3c767f-33d5de3]
            at net.minecraft.server.v1_8_R1.MinecraftServer.y(MinecraftServer.java:634) [spigot.jar:git-Spigot-c3c767f-33d5de3]
            at net.minecraft.server.v1_8_R1.MinecraftServer.run(MinecraftServer.java:537) [spigot.jar:git-Spigot-c3c767f-33d5de3]
            at java.lang.Thread.run(Thread.java:745) [?:1.8.0_11]
    

    Edited Mar 3, 2015

To post a comment, please login or register a new account.