chunk-entity-limiter: Plugin compatibility issues #222


Open
  • blablubb created this issue Jul 27, 2019

    Hey,

    the chunk-entity-limiter cancels creature spawns at monitor priority and does not ignore plugin-spawned mobs.

    Both of these two things are potential causes for plugin incompatibilities. Could you change the priority to something lower (so that other plugins can react to the event being cancelled), and also ignore (or add a setting to ignore) plugin-spawned mobs (spawn cause CUSTOM)?

    For reference of an incompatibility (potentially) caused by this: https://github.com/Shopkeepers/Shopkeepers/issues/587

  • blablubb edited description Jul 27, 2019
  • blablubb edited description Jul 27, 2019
  • bob7l posted a comment Jul 27, 2019

    It would cause issues with the remover if an entity were not removed that was marked to be removed. 

     

    What makes your villager entities stand out from normal ones? If they have a display name, then you can just do:

    - Villager !hasName

     

    That tells Clearlag to filter in or out (depending on the specification) villagers without a display name. 

  • fatherwh0 posted a comment Jul 27, 2019

    How do I specify with - Villager !hasName for it to filter out (ignore) villagers with names?

  • blablubb posted a comment Jul 27, 2019

    > What makes your villager entities stand out from normal ones?

     

    Is there an option to ignore entities with certain metadata keys (Shopkeepers uses 'shopkeeper'). If not, could you add one?

    I think I will also have to make some changes inside Shopkeepers for this to work, since right now the entity attributes are first applied after the entity was successfully spawned.

     

    Also, is there a way to define a general filter, such that any entity with a certain metadata key gets ignored (regardless of its type)? This would make configuring the plugin easier.. Shopkeepers for example allows spawning any mob type.

  • blablubb posted a comment Jul 28, 2019

    Something related to this and the linked issue: Could you ignore dead entities when counting entities in the chunk? There seem to be some situations in which the server will load and unload the chunk very frequently (see for example: https://hub.spigotmc.org/jira/browse/SPIGOT-5227). Any plugin spawning entities on chunk load and removing them again on chunk unload (like Shopkeepers) will temporarily produce a large number of dead entities in the chunk (entities which already have been marked for removal, but did not get removed yet by the server). Usually the server should remove those dead entities with the next tick (there seems to be some Spigot issue preventing this cleanup currently under certain circumstances though: https://hub.spigotmc.org/jira/browse/SPIGOT-5228).

     

    There should be no point for ClearLagg to count those already dead ('marked for removal') entities towards its limit(s).


    Edited Jul 28, 2019
  • bob7l posted a comment Jul 28, 2019

    Will add the metaData flag in the next release, and will also check for entities being alive before marking them for removal. Thanks


To post a comment, please login or register a new account.