All minecarts being removed despite item-filter(s) During Auto-removal #145


  • New
  • Defect
Open
Assigned to bob7l
  • _ForgeUser156606 created this issue Jun 26, 2016

    Pastebin link to your Config (I will ignore your ticket if it doesn't contain this:
    http://pastebin.com/B7N8n4vG&nbsp; <--- test config with notes (currently in prod)
    http://pastebin.com/5Nt1EUr8&nbsp;&nbsp; <--- original config from original install (unknow version, sorry)

    What steps will reproduce the problem?
    1. three small circular tracks with minecart (328), minecart with chest (342), and minecart with hopper (408)
    2. set config as follows:

    auto-removal:
      enabled: true
    ...
      world-filter:
      minecart: true
    ...
      item-filter:
      # hopper_minecart
      - 408
      # chest_minecart
      - 342
    ...
    ...
    command-remove:
      minecart: true
    ...
      item-filter:
      # hopper_minecart
      - 408
      # chest_minecart
      - 342

    3. wait for auto-removal to engage

    What is the expected output? What do you see instead?

         expect: unoccupied minecarts to be be removed.
         result: they are (occupied ones are left. as expected)

         Expect: minecart w/hopper and minecart w/chest to NOT be removed.
         result: they are removed (not what i want)

    What version of the product are you using?
    2.9.1

    Do you have an error log of what happened?
    not necessary. no errors.

    Please provide any additional information below.

    Objective: clear unoccupied minecarts but leave hopper and chest minecarts in the world.

    Under the "auto-removal" options in the config, setting "minecart" to TRUE will remove all types of minecarts despite "item-filter" settings. Setting "minecart" to FALSE will leave all minecart types (occupied or unoccupied). This is not what i wish to accomplish.

    With "auto-removal" set to TRUE, "minecart" set to TRUE and "item-filter" containing:
      # hopper_minecart
      - 408
      # chest_minecart
      - 342

    All minecarts are removed with the above settings.

    I looked at "command-remove" as well. setting it similar to the auto-removal. and then setting it opposite of auto-removal. The result was the same.

    The videos on the curse and bukkit site are old and I noticed some of the config categories were labeled differently. Perhaps this was changed in later clearlagg versions ??

    Then again, perhaps Im just overlooking something in the config. With due respect, the documentation is not exactly clear in every section. So i could misunderstand something. (although for my ego's sake I hope i didnt miss anything obvious haha)

    Thank you for taking the time to review this.

  • _ForgeUser156606 added the tags New Defect Jun 26, 2016
  • bob7l posted a comment Jun 27, 2016

    Your pastebins are private. You need to set them to public or unlisted.

  • _ForgeUser156606 posted a comment Jun 30, 2016

    done.

  • bob7l posted a comment Jul 1, 2016

    @sliverpix: Go

    Alright i understand now.

    Firstly, the item-filter only filters items that are dropped on the ground, not specific entities.

    Now the minecraft clearing will be an issue and isn't exactly configurable atm. So you'll have to disable it for now until i think of a cleaner option to allow users to program their config better.

    I've also been thinking of designing a wrapper for entityTypes so configuring will be something like this:

    entity-filter: - Cow name:"Cool Cow" - Pig named - Minecart occupied

    What that'll do is filter the entities depending on your specifications. So no Cow named "Cool Cow" would be removed, no Pig with a name will be removed, and finally no occupied Minecraft will be removed.

    This feature might be a bit too difficult for some newer server admins to understand, but i'll try my hardest to document it well.

  • bob7l posted a comment Jul 2, 2016

    Hey with build #30 on the development website you're now able to configure entities MUCH better which should meet your needs.

    Here is the new system example: http://dev.bukkit.org/bukkit-plugins/clearlagg/pages/config-setup/

  • _ForgeUser156606 posted a comment Jul 4, 2016

    @bob7l: Go

    now thats interesting .... is this active now for build #30 of clearlagg? lol.. guess i can go look that part up myself... just so dang busy.

    I think your idea to add more granular functionality is great! and I commend commitment. I know how hard it is. Keep it up!!

    I agree, its hard to add good documentation. Its time consuming. I do a lot of it at work.. but its never enough. If it helps, (does me anyway), i always try to add notes (which you did) to my code as I write it... really more for me and my crappy memory.. but others gain too. When I start adding a note, I always ask myself "can a 5th grader understand this?"... if my answer is no, I try to add/remove "verbage" until my answer is yes. An old coder once said "there is no such thing as too many notes"... he may have been intoxicated when he said that... soo you be the judge. :)

    anyway, before I further digress, ill dig into this some and see what transpires. APPRECIATE you being forthcoming and open minded bob7l.

    @bob7l: Go


To post a comment, please login or register a new account.