CitiTraders
CitiTraders
Currently working on CitiTraders 2 - Fixing alot of hold over errors and issues.
As I get a chance to update I will do on this page CitiTraders2
Cititraders enables your citizens 2 NPCs to act as traders, buying and selling goods. It works good for admin shops and player shops alike. All traders use the inventory interface for buy/sell and players don't need any commands to interact with Traders.
You can see more details at CitiTraders Wiki
Issues: Issues at JIRA
Recommended Builded: RC-5 Release Candidate
Development Builded: Jenkins lastSuccessful Build
Setting Up A Trader
Interacting
- Right Click the NPC
- Opens the selling window, here the players will select what item they wish to purchase from the NPC
- Right Click the Item
- displays a price of the item
- Left Click the Item
- Opens the final sales window, from here a player can right click again for stack price, or left click to purchase the stack
- Left Click the NPC
- this will open the buy window for NPC, currently players need to just drag and drop items to the inventory and close the window, unpurchased items are dropped if NPC can't purchase these items (soon they will not be able to be dropped into the inventory if NPC can't purchase them)
Adding Stock
- Right Click the NPC with a BOOK in your hand
- This will open an inventory screen where you can place any items you want to sell, if an ADMIN shop these items will not be reduced with sales, but you still need to put 64 (or max stack) of an item to get a full listing of amount in sales window.
- Linked Chests
- If you have linked chests, adding stock is as easy as opening the chest that is linked to the trader, and adding what you want to it.
Commands
Commands Permissions are currently listed here for CitiTraders 2
Permissions
Limits/Profiles
Installation
Just place into the plugins folder and restart the server, make sure you have a working version of Citizens2 and Vault installed first
Requirements
- Citizens 2
- Vault with economy plugin such as BOSEconomy and permissions such as zPermissions.
- (Optional) Towny
TODO
- Add shop managers and assistants
- rewrite selltoplayer to allow for easier buystack and to improve performance
Credits
- tehbeard - Original Author
- tenowg - Current Maintainer
So i'm getting errors and I found out that the current version of this doesn't work with 1.4.5.
Error :(
EditInstalled this version -> R: CitiTraders RC-5 for CB 1.3.2-R1.0 Oct 04, 2012 Funny thing is that if i buy something the plugin doesnt take money of my account. And also doesnt give it to the owner.
/npc owner (name) /trader create Bob /trader sellpirce 3.00 Put fish in stockroom /trader setwallet owner
Buying fish. Telling me that i both it and took the money of my bose account. But didnt do it. Any idea why?
The newest version is bugged so thats why im using the older version.
@L1amm
Still testing here but here is the page i am using http://wiki.citizensnpcs.com/Cititrader/Permissions
Does anyone know the permissions to use a trader? My players click traders and nothing opens, but it works fine for me as an op.
It will be updated to 1.4.5 d verision?
Error when typing anything with /trader xxxx
http://pastebin.com/8CdkGTH7
Hi im getting this error when i tried to use the book with rigth click on the character!
23.11 16:17:05 [Multicraft] Skipped 8 lines due to rate limit (30/s) 23.11 16:16:46 [Server] INFO at net.minecraft.server.EntityPlayer.openContainer(EntityPlayer.java:472) 23.11 16:16:46 [Server] INFO at net.minecraft.server.NetServerHandler.sendPacket(NetServerHandler.java:816) 23.11 16:16:46 [Server] INFO at net.minecraft.server.NetworkManager.queue(NetworkManager.java:82) 23.11 16:16:46 [Server] INFO at net.minecraft.server.Packet100OpenWindow.a(SourceFile:54) 23.11 16:16:46 [Server] INFO Caused by: java.lang.NullPointerException 23.11 16:16:46 [Server] INFO at net.minecraft.server.ThreadServerApplication.run(SourceFile:818) 23.11 16:16:46 [Server] INFO at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:401) 23.11 16:16:46 [Server] INFO at net.minecraft.server.MinecraftServer.q(MinecraftServer.java:475) 23.11 16:16:46 [Server] INFO at net.minecraft.server.DedicatedServer.r(DedicatedServer.java:219) 23.11 16:16:46 [Server] INFO at net.minecraft.server.MinecraftServer.r(MinecraftServer.java:564) 23.11 16:16:46 [Server] INFO at net.minecraft.server.DedicatedServerConnection.b(SourceFile:30) 23.11 16:16:46 [Server] INFO at net.minecraft.server.ServerConnection.b(ServerConnection.java:53) 23.11 16:16:46 [Server] INFO at net.minecraft.server.NetServerHandler.d(NetServerHandler.java:122) 23.11 16:16:46 [Server] INFO at net.minecraft.server.NetworkManager.b(NetworkManager.java:284) 23.11 16:16:46 [Server] INFO at net.minecraft.server.Packet7UseEntity.handle(SourceFile:36) 23.11 16:16:46 [Server] INFO at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:1086) 23.11 16:16:46 [Server] INFO at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:462) 23.11 16:16:46 [Server] INFO at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:477) 23.11 16:16:46 [Server] INFO at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) 23.11 16:16:46 [Server] INFO at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:322) 23.11 16:16:46 [Server] INFO at java.lang.reflect.Method.invoke(Method.java:601) 23.11 16:16:46 [Server] INFO at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) 23.11 16:16:46 [Server] INFO at sun.reflect.GeneratedMethodAccessor140.invoke(Unknown Source) 23.11 16:16:46 [Server] INFO at net.citizensnpcs.EventListen.onPlayerInteractEntity(EventListen.java:235) 23.11 16:16:46 [Server] INFO at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:462) 23.11 16:16:46 [Server] INFO at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:477) 23.11 16:16:46 [Server] INFO at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) 23.11 16:16:46 [Server] INFO at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:324) 23.11 16:16:46 [Server] INFO org.bukkit.event.EventException 23.11 16:16:46 [Server] SEVERE Could not pass event NPCRightClickEvent to CitiTrader vBETA-2.0
setwallet admn is not working for me ...
@Alexfire480
Just cititraders
@HerrGrim
I will retest on test server to be sure.
oh really? for all citizens stuff or just cititrader?
Afraid the command /trader setwallet admin gives no errors, but doesn't work. Using the command /trader setwallet gives a list of options, but no admin options. I've tried this as OP and regular with the correct permissions.
Also tried a new server with a fresh install of citizens2 and the lastest release of this plugin, but same problem.
@Alexfire480
In Beta 2 there is the option to use rightclick+sneak to open if pvp is disabled.
@siemaeniu500
There is an admin wallet in Beta 2, same as in the first CitiTrader.
Has anyone found a way to enable left clicking without having pvp enabled yet? or a plugin that disables all pvp without canceling the event I know worldguard can do it but RPG plugins with skills and what not can still damage the NPCs I really am at a loss how to disable pvp without disabling pvp lol ...
@tenowg
1.Sorry Buyprice is lower then sellprice. Players duplicating money with selling items, but i don't know how them do it that.
2.Why I citizensbeta 2 there isn't a admin wallet? People buing and items are remove from the npc. I don't using beta 2.0 because it haven't that.
@siemaeniu500
If the shop is admin wallet, and the buy price is higher than the sell price, then the player will buy it from the shop and sell it back for an infinite loop.
Buyprice should be lower then sellprice (sellprice is the price that the trader sells the item, buyprice is the price the traders buys the item)
I don't know how , but my players duplicating money with this plugin, all price ale set good, buyprice are higher then sellprice. I using latest CitiTraders RC-5 version of this plugin.
Some bug fixes
The update is waiting for approval, the November 2nd upload is not the fix, if you wish you may download from my jenkins link listed above.
@tastybukkit
I will look at the error for the wallet, but as far as the left clicking not working is because you have another plugin that is setting pvp to false to bukkit itself and the event is never getting fired.. I have added an alternative way to "left click" it is "rightclick + sneak"
The Outdate is expected as you are using a version that isn't ready for public release... so beta testing and see the outofdate is better than someone using the last recommended seeing it.
Nothing happens when I left click my trader. Right clicking functions good. I have set several items buy price.
Cititraders vBETA-2.0 Citizens2 v2.0.4-SNAPSHOT (build 559) git-Bukkit-1.4.2-R0.2-b2455jnks
other plugins:Plugins (28): PermissionsBukkit, CommandBook, BOSEconomy, Vault, LessFood, RemoteToolkitPlugin, dynmap, MineProwl, LockIP, ScrollingMenuSign, BeardStat, ExtraHardMode, BKCommonLib, Lockette, MineloadPlugin, GriefPrevention, mcMMO, FoundDiamonds, MineQuest, ShowCaseStandalone, Citizens, PluginsBaker, JSONAPI, MineQuest-Idle, MineQuest-Events, BeardAch, CitiTrader, iProfessions
When I issue command /trader wallet balance and right click NPC, I get the following:
No enought items item to purchase? Wallet: admin What i must do?