Bukkit

> I'm copying the issue/description of @finamenon over from the plugins comment section <

@finamenon said:

I think you're definitely on the right track, however in our testing we ran into really strange errors when shift clicking trades. Sometimes it would give us way too many of the item to be given to the player, then randomly disappear, other times it wasn't taking away the proper amount of emeralds.

I also found that behavior on our tests but that really seems to be a vanilla display/client error here. Mojang seems to have missed to change the client behavior to their new offer-removal system for those trades. You can check that by clicking one of the items you got too many. They will just disappear and the correct amount of money/items will be put back into the slots above. Also just closing the trade window should still just sell/buy the correct max-amount and throw out the rest of the payment then ;-)

@finamenon said:

Cube Ill make it a point to test this again tomorrow and get back to you. Though I know for sure that the errors we were encountering were randomly persisting. We have a trade that is 1 emerald for 4 glass. We were trying to trade a whole stack of emeralds, getting the display of the appropriate amount of glass. Then we would get the emeralds back minus the cap but still have the glass even on relogs and inventory management.

On a trade that offers 5 bread per 1 emerald traded, I just shift clicked a stack of emeralds, got 4.5 stacks of bread, and then got 58 emeralds back. Still have the bread D:

Do you have any villager trading related plugin besides this one? Feel free to send me you plugin list by PN for sure :-) Which version of craftbukkit are you running?

I really can't reproduce that. I've set up a villager with those trades and the default chance of 20-40 trades for an item being removed. I put 64 emeralds into the slot, shift-click the bread and I then get 5 stacks of bread and all emeralds are gone. Since this is just a display/client issue I can now do two things:

1. I just close the window. Which will then drop around 40 emeralds (meaning the randomness was 24 trades here) + leaving me just the 24*5 (120) bread in my inventory

2. I tap one of the (too many) breads and it instantly updates the UI, getting back 38 emeralds in slot 1 (so the max trade amount was 26 now) + updating the bought bread to the corresponding 130 bread finally

So everything works as it should.

But I found one inconsistency in your description. You say the villager offers 5 bread for 1 emerald, right? So you put emeralds into the slot1 and get bread from the right slot. Wouldn't you then shift click the bread instead of the emeralds, like you wrote?

Shift clicking the emeralds from the inventory just switches it between the inventory and the slot bar for me - no inventory sorting mod or else here.

@finamenon said:

I currently use no other plugins that affect trading, and I am using craftbukkit beta 1.4.5-0.2. By shift clicking I mean I am shift clicking the bread, not the emeralds. Shift clicking the emeralds from my inventory doesn't actually do anything. I have to manually drop them into the window.

Any updates on this?

Still waiting on word whether or not this is fixed or can be reproduced.