Rules getting logged without "then log" in them #52


  • Defect
  • New
  • Waiting
Open
Assigned to erronload
  • Seirako created this issue Feb 8, 2014

    Using Pwnfilter 3.3.0 with config settings set like these:

    loglevel: fine
    logfile: true
    debug: off
    

    When using a rule similar to:

    match j(oin)? .
    require permission disguisecraft.mob.chicken
    require command /ma|/mobarena
    then console u %player%
    

    Even though the filter rule does not have "then log" in it, if a player types the command "/hg join 1", it will log the following to the pwnfilter.log file:

    Quote from pwnfilter.log when player DOES have the permission "disguisecraft.mob.chicken":

    [2014/02/08 20:55:50] [PwnFilter] |COMMAND| MATCH <notTest> /hg join 1
    [2014/02/08 20:55:50] [PwnFilter] CONDITION not met <require command /ma|/mobarena> /hg join 1
    [2014/02/08 20:55:50] [PwnFilter] |COMMAND| SENT <notTest> /hg join 1

    Quote from pwnfilter.log when player DOESN'T have the permission "disguisecraft.mob.chicken":

    [2014/02/08 20:56:57] [PwnFilter] |COMMAND| MATCH <notTest> /hg join 1
    [2014/02/08 20:56:57] [PwnFilter] CONDITION not met <require permission disguisecraft.mob.chicken> /hg join 1
    [2014/02/08 20:56:57] [PwnFilter] |COMMAND| SENT <notTest> /hg join 1


    When using a rule similar to:

    match ^\/ho\b
    then replace /helpop
    

    Even though the filter rule does not have "then log" in it, if a player types the command "/ho testing helpop shortcut", it will log the following to the pwnfilter.log file:

    Quote from pwnfilter.log:

    [2014/02/08 21:05:02] [PwnFilter] |COMMAND| MATCH <notTest> /ho testing helpop shortcut
    [2014/02/08 21:05:02] [PwnFilter] |COMMAND| SENT <notTest> /helpop testing helpop shortcut


    When using a rule similar to:

    match damn
    then warn Do not say "damn"
    

    Even though the filter rule does not have "then log" in it, if a player types something with the word "damn" in it, it will log the following to the pwnfilter.log file:

    Quote from pwnfilter.log:

    [2014/02/08 22:33:57] [PwnFilter] |COMMAND| MATCH <notTest> /tell anotherPlayer damn you
    [2014/02/08 22:33:57] [PwnFilter] Warned notTest: Do not say "damn"

  • Seirako added the tags New Defect Feb 8, 2014
  • Seirako edited description Feb 8, 2014
  • _ForgeUser10620973 posted a comment Apr 29, 2014

    Not a bug. This is by design.

    The "loglevel: fine" prevents the match messages from appearing on the console.

    The debug: off stops debugging information.

    But if you have logfile: true, there will be a log entry every time PwnFilter matches. This is actually old behaviour, that I had to preserve for backwards compatibility.

    I can see that this might cause too much log info. I'll try to create a better setup for the future.

    -Sage


    Edited Jun 3, 2014
  • _ForgeUser10620973 posted a comment Sep 13, 2015

    I've been going through old tickets, and I'm not sure what to do about this one.

    My choices seem to be:

    1. Remove all "Match" logging, unless "then log" is specified
    2. Create a new config flag that allows the toggling of "Match" logging behaviour described in #1
    3. Do nothing. :)
    4. Suggestions?

    I'm tempted to do #3, unless you have a better suggestion?

  • _ForgeUser10620973 removed a tag Accepted Sep 13, 2015
  • _ForgeUser10620973 added a tag Waiting Sep 13, 2015

To post a comment, please login or register a new account.