nondeterministic world name mapping #83


  • New
  • Patch
Open
Assigned to _ForgeUser7502837
  • _ForgeUser6887391 created this issue Feb 9, 2013

    https://github.com/sleelin/PvPToggle/pull/1

    What steps will reproduce the problem?
    Using MultiVerse with worlds where one name is contained in another (public/public_nether), under the right conditions players in world "public" would not get PvPToggle protection because the plugin thought the user was in world "public_nether". This is because PvPToggle tests for each world listed by Bukkit if worlda.contains(worldb). Thus if worlda is "public_nether" and worldb is "public", the test returns true, even though there is a more exact match for the world name.

    What is the expected output?
    A player in world "public" should get treated as if they are in world "public".

    What do you see instead?
    A player in world "public" gets treated as they are in world "public_nether"

    What version are you using?
    v3.0.0 / compiled from git src

    Do you have an error log of what happened?
    no

    Please provide any additional information below:
    I've submitted a fix that will do partial world name matches only if there is one world name that is matched. Otherwise it requires an exact name match.

    https://github.com/sleelin/PvPToggle/pull/1

  • _ForgeUser6887391 added the tags New Patch Feb 9, 2013

To post a comment, please login or register a new account.