MobArena

2 - Mob Arena going double? [Heroes]

What steps will reproduce the problem? (Leave blank if you don't know)
1. Enter mob arena with 1 or more people.
2. Using heroes spells advance past round 1.
3. Have all party members die.

What happens when you follow these steps? What should happen instead?
MobArena doesn't end and rounds start doubling up (mobs stay). MobArena should end the round.

What version of MobArena are you using?
Newest? Bukkit dev doesnt say.

Do you have an error log of what happened? (Please use http://pastebin.com/)
No.

Please provide any additional information below.
You actually die with heroes and don't get respawned in the spectator area.

User When Change
garbagemule Sep 25, 2011 at 14:38 UTC
binarytoshokan Sep 14, 2011 at 21:36 UTC
garbagemule Sep 14, 2011 at 14:04 UTC
garbagemule Sep 13, 2011 at 15:56 UTC
garbagemule Sep 12, 2011 at 21:50 UTC
garbagemule Sep 03, 2011 at 04:14 UTC
garbagemule Sep 03, 2011 at 04:13 UTC
garbagemule Sep 02, 2011 at 11:31 UTC
garbagemule Aug 29, 2011 at 05:45 UTC Changed name from Mob Arena going double? to Mob Arena going double? [Heroes]
MadcowD Aug 28, 2011 at 05:41 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • Avatar of garbagemule garbagemule Sep 15, 2011 at 05:55 UTC - 0 likes

    @binarytoshokan: Go

    I still cannot reproduce the error :( I never die upon arena death. I always get warped back to the spectator area with full health. Perhaps it's a delay issue? I've only tested on a local test-server, and thus not on a live server yet (it's difficult, as my live server doesn't use Heroes).

    /hp reveals 79 health points before joining, and 79 health points after the match. I also tested by joining with less than full health - still no deaths on about 10-12 rounds (lost count). I tried dying to spiders, skeletons and zombies.

    BFAK:75176,e83b8431e9cc274e2313e8b99b5d4193ff48b18bec478c66c4b090c8b8003bc9

  • Avatar of binarytoshokan binarytoshokan Sep 14, 2011 at 21:36 UTC - 0 likes

    Sorry for the delay.  Anyways, here's the updated Heroes configuration for you.  Just replace the current plugins/heroes folder with the contents of the compressed file.

    http://www.megaupload.com/?d=96HGTNFU

    Here's a few heroes commands that'll be useful.

                   Help - /hero
     Choose Class - /hero choose NameOfClass
    List of Classes - /hero paths
    Current Health - /hp

    Last edited Sep 14, 2011 by binarytoshokan
  • Avatar of garbagemule garbagemule Sep 14, 2011 at 14:04 UTC - 0 likes

    @binarytoshokan: Go

    Very interesting.

    Would it be possible for you to create a complete set of Heroes and player data files that will reproduce the error, so all I have to do is log in and join MobArena, i.e. can you make all the settings necessary for 'garbagemule' to log in and have all these settings applied? I'm very, very new with Heroes, and I figure it'll be easier for you than for me :P

    Thanks for the previous server files, though! Very helpful :)

  • Avatar of binarytoshokan binarytoshokan Sep 14, 2011 at 12:17 UTC - 0 likes

    @garbagemule: Go

    The exact same files are what I used to test before posting and my 50 tests or so just now.

    The one thing I noticed is that it is very inconsistent. I did not test the squire earlier(everything but that tested earlier), so I limited this session to just the squire class. I also did not progress past the first special round on these tests. I also used the Rogue Heroes class as a level 50. So my Heroes HP was 30 instead of the base 20.

    I would join the arena, choose squire then enter the arena. I would choose a monster type out of the random ones that spawn and I would die to that type. The majority of these I did no damage to any mob. But when I did attack a mob it did not seem to change the outcome. I also did not use any food during these tests(did on the previous test yesterday).

    For my results, I did not see any deaths from wolfs. 1 death from a zombie, at least 7 from spider(I stopped counting because this one happened the most) and 3 times out of limited 6 skeleton spawns. No creepers were tested. There was also streaks where it would work perfectly. I'd lose and get restored to properly without the death event.

    In good news, I did not notice HP0-Living occurring at all.

    You said you only used the Squire Heroes class. I have not noticed this happening when using that class. This is most likely because the Heroes max HP is the same as the standard minecraft HP, 20. All the other classes I have configured will start at 20HP and then gain HP/Level. So they end up with more than 20HP after a few levels.

    Last edited Sep 14, 2011 by binarytoshokan
  • Avatar of garbagemule garbagemule Sep 14, 2011 at 08:19 UTC - 0 likes

    This is odd...

    I downloaded your server zip, extracted it, ran the win-startmcserver.bat file, logged in, joined MobArena and played 10 rounds, and did not die upon arena death a single time. Are you absolutely sure that these server files are enough to reproduce the error?

    If so, please describe in excruciatingly thorough details every step to reproduce it (stuff like whether you hit the first mob first or the mob hits you before you hit any mobs, which monster you die to, which class you chose, which Heroes class you are (I was only the Squire), are all important).

    Cheers,
    mule

  • Avatar of binarytoshokan binarytoshokan Sep 14, 2011 at 02:48 UTC - 0 likes

    @garbagemule: Go

    First off, thank you for taking the time to resolve this issue.

    Now, unfortunately it does not appear to be fixed under v0.94.2. I tried that version instead of the dev one you linked since it was your newest release and was mentioned that the issue was fixed in that version.

    I still end up with 0 hp after the arena match, or just out-right dead. However, I do seem to end up dead more often than 0hp-alive with the fix.

    I trimmed my server files down to the minimum required to reproduce the issue and uploaded it to megaupload. Here is the link to the server files with my exact configuration. I hope this helps. http://www.megaupload.com/?d=PRSS7MF0 (7zip archive, no password, 33.13MB)

    Last edited Sep 14, 2011 by binarytoshokan
  • Avatar of garbagemule garbagemule Sep 12, 2011 at 21:50 UTC - 0 likes

    @binarytoshokan @MadcowD

    Please try the latest dev build of MobArena. I added some checks and tried fixing Heroes compatibility. It should work now.

  • Avatar of garbagemule garbagemule Sep 03, 2011 at 04:13 UTC - 0 likes

    @binarytoshokan: Go

    Thanks for the additional info! I have located the conflicting section of the Heroes code and suggested a simple fix that actually does what you suggested (resetting to max health upon death). My suggestion is only 2-3 lines of code that need to be added to Heroes, and it is by far the easiest fix in either direction. This is the code snippet:

    if (((Player) defender).getHealth() > 0) {
        heroDefender.setHealth(heroDefender.getMaxHealth());
        return;
    }
    

    And it would have to be inserted between lines 52 and 53 in this listener. I would very much appreciate it if you guys could try to convince the Heroes developers to add this simple check, such that no one has to use anyone's API unnecessarily :)

    Flagging this as verified for now...

    Edit: Changed my mind. Waiting for more information from the Heroes developers...

    Last edited Sep 03, 2011 by garbagemule
  • Avatar of binarytoshokan binarytoshokan Sep 02, 2011 at 20:52 UTC - 0 likes

    True, it does not happen when people don't have more than 20 max health. But being forced to use a max of 20hp renders a whole feature of the heroes plugin completely useless. Being able to modify the max health of a player I find very useful for balancing classes and as an extra reward for playing the arena often.

    Additional Information: I've checked the Heroes HP when this bugs out, and it ends up saying 0HP(heroes) but the player is alive. Because of the player being alive with 0hp(heroes), the next time they have a damage/heal event they die instantly.

    If I have any time tomorrow, I may take a look into the source of Mob Arena and see if I can come up with a quick fix. I believe simply updating the Heroes HP to max upon leaving the arena would fix the issue.

  • Avatar of garbagemule garbagemule Sep 02, 2011 at 11:32 UTC - 0 likes

    Interesting. Is there a way to always ensure that players don't have more than 20 health points?

Facts

Last updated
Sep 25, 2011
Reported
Aug 28, 2011
Status
Fixed - Developer made requested changes. QA should verify.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees