Bukkit

I'm getting this in my server log with most recent server update:

[10:30:19] [Server thread/WARN]: Plugin `Bottles_of_Wisdom v1.1' uses the space-character (0x20) in its name `Bottles of Wisdom' - this is discouraged

I was able to fix this on my end by editing plugin.yml inside the .jar file and modify the following:

From:

name: Bottles of Wisdom

To:

name: Bottles_of_Wisdom

Environment

• Server: Ubuntu Server 12.04.4 LTS, 64-bit
• Java: Oracle JRE 1.7.0_51, 64-bit)
• Minecraft: Spigot 1.7.5-R0.1 Build 1385
• Plugins: Bottles of Wisdom 1.1

Thanks,

LHammonds

FYI - A recent update of the server (R0.4 I think) now automatically replaces any spaces in plugin sub-folders with underscores. It turns out that it created a "plugins/Bottles_of_Wisdom" folder and no longer referenced the "plugins/Bottles of Wisdom" folder which had all the correct configurations.

Environment

• Server: Ubuntu Server 12.04.4 LTS (64-bit)
• Minecraft: Spigot 1.7.2-R0.4 Build 1324
• Java: 1.7.0_51 (64-bit)

Thanks,

LHammonds

thanks for the consideration man thats awsomew cant wait for the vault and area stuff you are awsome @pr1ke

Any chance you would make this open source?

Hey,

would be nice when the annoying break message could be complety switched off in config.yml. Or set off for standard and only who does /bottle silence gets the message displayed.

Any chance of a 1.7 update? It seems to work fine when starting the server, but randomly fills the console with a bunch of errors. I haven't figured out what starts the error every time, but once it was a player getting a /kit that included xp bottles. Trying to reproduce the error didn't work when I gave the kit to myself?

Thanks!!

Here is a sample of the error:

[Server thread/ERROR]: Could not pass event PlayerInteractEvent to Bottles of Wisdom v1.1 org.bukkit.event.EventException at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:427) [spigot.jar:git-Spigot-1177] at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) [spigot.jar:git-Spigot-1177] at org.bukkit.plugin.TimedRegisteredListener.callEvent(TimedRegisteredListener.java:30) [spigot.jar:git-Spigot-1177] at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:478) [spigot.jar:git-Spigot-1177] at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:463) [spigot.jar:git-Spigot-1177] at org.bukkit.craftbukkit.v1_7_R1.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:208) [spigot.jar:git-Spigot-1177] at net.minecraft.server.v1_7_R1.PlayerInteractManager.interact(PlayerInteractManager.java:375) [spigot.jar:git-Spigot-1177] at net.minecraft.server.v1_7_R1.PlayerConnection.a(PlayerConnection.java:627) [spigot.jar:git-Spigot-1177] at net.minecraft.server.v1_7_R1.PacketPlayInBlockPlace.a(SourceFile:60) [spigot.jar:git-Spigot-1177] at net.minecraft.server.v1_7_R1.PacketPlayInBlockPlace.handle(SourceFile:9) [spigot.jar:git-Spigot-1177] at net.minecraft.server.v1_7_R1.NetworkManager.a(NetworkManager.java:146) [spigot.jar:git-Spigot-1177] at net.minecraft.server.v1_7_R1.ServerConnection.c(SourceFile:134) [spigot.jar:git-Spigot-1177] at net.minecraft.server.v1_7_R1.MinecraftServer.u(MinecraftServer.java:647) [spigot.jar:git-Spigot-1177] at net.minecraft.server.v1_7_R1.DedicatedServer.u(DedicatedServer.java:259) [spigot.jar:git-Spigot-1177] at net.minecraft.server.v1_7_R1.MinecraftServer.t(MinecraftServer.java:530) [spigot.jar:git-Spigot-1177] at net.minecraft.server.v1_7_R1.MinecraftServer.run(MinecraftServer.java:442) [spigot.jar:git-Spigot-1177] at net.minecraft.server.v1_7_R1.ThreadServerApplication.run(SourceFile:617) [spigot.jar:git-Spigot-1177] Caused by: java.lang.NullPointerException at de.geckocraft.pr1ke.bottlingEXP.hitListener(bottlingEXP.java:393) [?:?] at de.geckocraft.pr1ke.listener.onAction(listener.java:29) [?:?] at sun.reflect.GeneratedMethodAccessor64.invoke(Unknown Source) [?:?] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [?:1.7.0_45] at java.lang.reflect.Method.invoke(Method.java:606) [?:1.7.0_45] at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:425) [spigot.jar:git-Spigot-1177]

Just curious - I changed some of the default messages in the config, but they aren't changing in game. Is there a missing link in the code?

Also couple of typos in your help text you might want to fix:

under "bottle check" line you have the word "Bottley"

and under "/bottle convert" line you have the word "Entchanting"

under "/bottle silence" is the mispelled "recieve" and missing an apostrophe in "dont"

Also, it would be nice to have a default true/false setting for the bottle breaking chat message in the config file, since going through a stack of bottle quickly fills your whole chat window and I don't know how easily some players can find the /bottle silence command.

Thanks for the fun plugin!

Misty Cloudkidz

I'm testing 1.1 right now (on my local PC) and the messages are working perfectly now. However, I think a misplaced "end if" is cropping up. After enchanting some bottles, I am not able to break the bottles and no XP is transferred. It toggles between 36 and 37 bottles in my hand after trying to break them over and over. It does not matter if silence mode is on or off.

Thanks,

LHammonds

Thanks for the update. I'm now running BoW 1.0 but still have the problems reported in my last post. Verified on Linux and on Windows with default configuration in regards to displaying the text when typing the command "/bottle create abc"

I think the solution is to remove the spaces in the variable names in the config...but it has to be done in the plugin code.

Current default config.yml:

exp-taken: 50
exp-given: 50
bottle breaks: '[BoW] The Bottle breaks, releasing its wisdom'
no bottle in hand: '[BoW] You must hold enough Glass Bottles in your hand to do that!'
bottle check: '[BoW] You have :EXP: experience Points, which equals :bottle: Bottle(s) of Wisdom.'
no Permission: '[BoW] You shout the Command, but nothing happens.'
not enough exp: '[BoW] You dont have enough Experience Points to do that!'
bottle created:  '[BoW] You created :bottle: Bottle(s) of Wisdom'
Muted: '[BoW] The bottles are now breaking silently'
Unmuted: '[BoW] The bottles are making noise again'
Argument isnt a Number: '[BoW] The argument after create has to be a Number.'
Reload: '[BoW] Reloaded!'

Recommended config.yml:

exp-taken: 50
exp-given: 50
bottle-breaks: '[BoW] The Bottle breaks, releasing its wisdom'
no-bottle-in-hand: '[BoW] You must hold enough Glass Bottles in your hand to do that!'
bottle-check: '[BoW] You have :EXP: experience Points, which equals :bottle: Bottle(s) of Wisdom.'
no-Permission: '[BoW] You shout the Command, but nothing happens.'
not-enough-exp: '[BoW] You dont have enough Experience Points to do that!'
bottle-created:  '[BoW] You created :bottle: Bottle(s) of Wisdom'
Muted: '[BoW] The bottles are now breaking silently'
Unmuted: '[BoW] The bottles are making noise again'
Argument-isnt-a-Number: '[BoW] The argument after create has to be a Number.'
Reload: '[BoW] Reloaded!'

Thanks,

LHammonds

can you make it so the plugin hooks into vault and uses an economy plugin to create the exp bottles at a cost? and maybe make it so you have to be around a special structure or sign in order to do said tasks.lol just an idea, I havent tried the plugin before but i dont want to give this feature for free because it could create an inballance when coupled with plugins such as silkspawners.

Thanks Guy! let me know

Thanks again for the quick update. Version 1.87b is now installed. I have confirmed the mute, unmute and reload message are being pulled from the config. However, I am getting a "null" message when I type "/bottle create abc" instead of the "argument has to be a number" message.

I'm not sure if I have a typo in the config causing this problem or not. I'm too sleepy at the moment and will test a bit more tomorrow.

EDIT: 2013-09-30

Ok, I think this is a Linux / yml / parsing thing.

When I edit the file using vi editor (in Linux) it knows it is a YAML file and tries to color code the lines/text. It has a problem showing the "Arguments" line. I tried all kinds of tricks to get it to work but only 1 thing did. That was to remove the spaces from the variable names.

Example:

exp-taken: 50
exp-given: 50
bottlebreaks: '§6[Info]§a The bottle breaks, releasing its wisdom.'
nobottleinhand: '§6[Info]§a You must hold enough glass bottles in your hand to do that!'
bottlecheck: '§6[Info]§a You have :EXP: experience points, which equals :bottle: Bottle(s) of Wisdom.'
noPermission: '§6[Info]§a You shout the command but nothing happens.'
notenoughexp: '§6[Info]§a You dont have enough experience points to do that!'
bottlecreated:  '§6[Info]§a You created :bottle: Bottle(s) of Wisdom.'
Muted: '§6[Info]§a The bottles are now breaking silently.'
Unmuted: '§6[Info]§a The bottles are making noise again.'
Reload: '§6[Info]§a Reloaded!'
ArgumentisntaNumber: '§6[Info]§a The argument after create has to be a number.'

When the spaces were removed from the variable names, it had no problem color coding and parsing the lines.

The color code symbol also seems to be playing a part of the problem but I cannot use the & symbol. Has to be the § symbol for color to work.

The spaces and color symbol together might be causing the issue.

Thanks,

LHammonds

Thanks for fixing it so quick. It also seems it was approved quickly too! Sweet.

EDIT 2013-09-29:

I'm now using 1.86b. I deleted my config.yml and let the plugin generate a new one to get the new messages. After I customized the messages and did a reload, I noticed some message changes took effect and others did not. I shutdown the server, check the config again and it looks OK. Started the server and tried again but noticed the following messages are not pulling the text from the config:

Muted: '[Info] The bottles are now breaking silently.'
Unmuted: '[Info] The bottles are making noise again.'
Argument isnt a Number: '[Info] The argument after create has to be a number.'
Reload: '[Info] Reloaded!'

I believe these variables are the ones most-recently added.

LHammonds

I'm now running 1.85b but noticed a small bug. When you type "/bottle silence" it shows the help page along with the silence notification.

The "/bottle" and "/bottle help" show the help pages as expected.

Thanks,

LHammonds